Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter announcement txns pending import #6932

Merged
merged 2 commits into from
Mar 2, 2024
Merged

Filter announcement txns pending import #6932

merged 2 commits into from
Mar 2, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Mar 2, 2024

Closes #6930.

  • Adds a filtering step on reception of an announcement to filter out transactions that are pending import to pool.
  • Leaves transactions that have been successfully fetched in tx fetcher until they are added to the pending pool import queue to make sure they aren't fetched again.

Should significantly reduces network load.

@emhane emhane added C-perf A change motivated by improving speed, memory usage or disk footprint A-networking Related to networking in general labels Mar 2, 2024
mattsse
mattsse reviewed Mar 2, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice,

one q re the moved remove_hashes_from_transaction_fetcher call

crates/net/network/src/transactions/mod.rs Show resolved Hide resolved
mattsse
mattsse approved these changes Mar 2, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I misinterepreted the remove call in on_resolved_get_pooled_transactions_request_fut

lgtm

@emhane emhane added this pull request to the merge queue Mar 2, 2024
Merged via the queue into main with commit ef7ce36 Mar 2, 2024
29 checks passed
@emhane emhane deleted the emhane/filter-announcement-txns-pending-import branch March 2, 2024 19:02
@emhane emhane added the C-bug An unexpected or incorrect behavior label Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-networking Related to networking in general C-bug An unexpected or incorrect behavior C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't fetch txns that are pending pool import
2 participants
@emhane @mattsse