Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txpool: track failed delete blobs in cleanup #6952

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Mar 4, 2024

As the blob files were deleted in async mode, and the cleanup will truly delete the under blob files, so we should track the blobstore_failed_deletes in cleanup instead of delete_blob{s}

@jsvisa jsvisa requested a review from mattsse as a code owner March 4, 2024 01:58
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes sense,

I'd like to use a struct container type so we can easily add more fields, perhaps we also want to rescan the dir

crates/transaction-pool/src/blobstore/mod.rs Outdated Show resolved Hide resolved
@mattsse mattsse added the A-tx-pool Related to the transaction mempool label Mar 4, 2024
mattsse
mattsse previously approved these changes Mar 4, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last pedantic nit

crates/transaction-pool/src/blobstore/mod.rs Outdated Show resolved Hide resolved
crates/transaction-pool/src/blobstore/mod.rs Outdated Show resolved Hide resolved
@mattsse mattsse dismissed their stale review March 4, 2024 13:48

should be change req

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattsse mattsse added this pull request to the merge queue Mar 4, 2024
Merged via the queue into paradigmxyz:main with commit 1214f2d Mar 4, 2024
29 checks passed
@jsvisa jsvisa deleted the blob-cleanup branch March 5, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tx-pool Related to the transaction mempool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants