Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smallvec dependency conflict #6956

Merged

Conversation

ckoopmann
Copy link
Contributor

@ckoopmann ckoopmann commented Mar 4, 2024

Currently when trying to install reth as a library, there is an error due to conflicting nested dependencies on the `smallvec package. (See this ci failure).

This pr in it's current version fixes that specific conflict, which however uncovers another conflict regarding "bitflags". (see this other ci failure).

This leads me to wonder wether I am doing something wrong when importing reth like this, or if not wether there is something else that can be done on reth ci side to avoid such issues in the future. (i.e. adding some ci step that ensures that the current version is actually installable as cargo dependency).

@ckoopmann ckoopmann requested a review from gakonst as a code owner March 4, 2024 11:40
@mattsse mattsse added the A-dependencies Pull requests or issues that are about dependencies label Mar 4, 2024
@mattsse
Copy link
Collaborator

mattsse commented Mar 4, 2024

I think this can be solved by manually updating the lockfile cargo update -p smallvec

but I think we can also do this

wdyt @DaniPopes

Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. In general if you have these sorts of problems it's good to first check cargo update, or in extreme cases deleting Cargo.lock entirely

@DaniPopes DaniPopes added this pull request to the merge queue Mar 5, 2024
Merged via the queue into paradigmxyz:main with commit 176ce4f Mar 5, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Pull requests or issues that are about dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants