chore(node-core): log errors in debug when ETA fails to calculate #6971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Mar 5, 2024
rkrasiuk
reviewed
Mar 6, 2024
Comment on lines
+486
to
+500
| let Some(processed_since_last) = | ||
| current.processed.checked_sub(self.last_checkpoint.processed) | ||
| else { | ||
| self.eta = None; | ||
| debug!(target: "reth::cli", ?current, ?self.last_checkpoint, "Failed to calculate the ETA: processed entities is less than the last checkpoint"); | ||
| return | ||
| }; | ||
| let elapsed = last_checkpoint_time.elapsed(); | ||
| let per_second = processed_since_last as f64 / elapsed.as_secs_f64(); | ||
|
|
||
| self.eta = Duration::try_from_secs_f64( | ||
| ((current.total - current.processed) as f64) / per_second, | ||
| ) | ||
| .ok(); | ||
| let Some(remaining) = current.total.checked_sub(current.processed) else { | ||
| self.eta = None; | ||
| debug!(target: "reth::cli", ?current, "Failed to calculate the ETA: total entities is less than processed entities"); | ||
| return | ||
| }; |
There was a problem hiding this comment.
let's add stage_id arg to Eta::update and log it as well to identify the source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't instantly identify the source of this debug mode panic
So instead, on subtract with overflow, we log the error on debug level and reset the ETA instead of crashing or reporting the invalid ETA.