Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stages): calculate checkpoints from static files #6973

Merged
merged 1 commit into from
Mar 5, 2024
Merged

fix(stages): calculate checkpoints from static files #6973

merged 1 commit into from
Mar 5, 2024

Conversation

shekhirin
Copy link
Collaborator

reth/crates/stages/src/stages/bodies.rs

Lines 346 to 348 in 4b758e1

// Count only static files entries. If we count the database entries too, we may have
// duplicates. We're sure that the static files have all entries that database has,
// because we run the `StaticFileProducer` before starting the pipeline.

@shekhirin shekhirin added C-bug An unexpected or incorrect behavior A-observability Related to tracing, metrics, logs and other observability tools A-static-files Related to static files labels Mar 5, 2024
@shekhirin shekhirin mentioned this pull request Mar 5, 2024
Merged
@shekhirin shekhirin added this pull request to the merge queue Mar 5, 2024
Merged via the queue into main with commit c8df172 Mar 5, 2024
29 checks passed
@shekhirin shekhirin deleted the alexey/stage-checkpoint-static-files branch March 5, 2024 19:31
@emhane emhane mentioned this pull request Mar 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshieDo joshieDo joshieDo approved these changes

@mattsse mattsse Awaiting requested review from mattsse

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

Assignees
No one assigned
Labels
A-observability Related to tracing, metrics, logs and other observability tools A-static-files Related to static files C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shekhirin @joshieDo