Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/test: speed up tests #6987

Merged
merged 6 commits into from
Mar 6, 2024
Merged

ci/test: speed up tests #6987

merged 6 commits into from
Mar 6, 2024

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Mar 6, 2024

We use proptest and keccak256 a lot, so make them way faster for a very small, insignificant cost to compile time, which is cached anyway in CI.

Some slow tests on my machine and CI

  • SealedBlockTests::proptest: 20s to 2s, CI 60s, to 3.2s
  • timestamped_forks: 12.5s to 1.5s, CI 42.5s, to 4.7s
  • fuzz_state_root_incremental: 11.1s to 2.15s, CI 25s, to 4.2s
  • prune_receipts_by_logs: 3.5s to 0.5s

There are 2 tests that are hard coded to sleep 60s which is not ideal (long_read_transaction_safety_disabled), added in #6181 by @shekhirin. I don't know enough about that part of the code base to reduce their running time. #6994

stage_checkpoint_pruned and execute_intermediate_commit are flaky, the first run it times out, then runs fine.

Remaining slow tests are quite a few networking tests that also look hard coded to 5 / 10 seconds, like txn_manager_read_transactions_duration_unbounded, test_backoff_on_no_response, cc @emhane @mattsse if there's anything we can do to make them faster, or if there's even a point in doing so.


I've removed partitions for integration tests since the total running time is <30s with a 5m compile time, there is no point in splitting them.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

can take a look at the net tests separately

@DaniPopes DaniPopes enabled auto-merge March 6, 2024 13:20
@DaniPopes DaniPopes added this pull request to the merge queue Mar 6, 2024
Merged via the queue into main with commit e42fb32 Mar 6, 2024
27 checks passed
@DaniPopes DaniPopes deleted the dani/faster-tests branch March 6, 2024 13:43
@DaniPopes DaniPopes mentioned this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants