Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Canyon timestamp overflow #6990

Merged
merged 1 commit into from
Mar 6, 2024
Merged

fix: Canyon timestamp overflow #6990

merged 1 commit into from
Mar 6, 2024

Conversation

yjhmelody
Copy link
Contributor

@yjhmelody yjhmelody commented Mar 6, 2024 •
edited
Loading

Seems now canyon could not be confiured at genesis, right?. And this timestamp may be overflow when timestamp is zero.

@yjhmelody yjhmelody requested a review from mattsse as a code owner March 6, 2024 09:02
@rkrasiuk rkrasiuk added C-bug An unexpected or incorrect behavior A-op-reth Related to Optimism and op-reth labels Mar 6, 2024
mattsse
mattsse approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm timestamp should not be zero, but better safe than sorry here

@mattsse mattsse added this pull request to the merge queue Mar 6, 2024
Merged via the queue into paradigmxyz:main with commit 2d6ad17 Mar 6, 2024
29 checks passed
@yjhmelody yjhmelody deleted the fix/sub-overflow branch March 6, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rkrasiuk rkrasiuk rkrasiuk approved these changes

Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yjhmelody @mattsse @rkrasiuk