Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: hive build-args #7013

Merged
merged 1 commit into from
Mar 6, 2024
Merged

bugfix: hive build-args #7013

merged 1 commit into from
Mar 6, 2024

Conversation

rswanson
Copy link
Collaborator

@rswanson rswanson commented Mar 6, 2024

Discovered a bug in the newly added build arg that stemmed from how the docker/build-push-action parses that field. Tested the run and this will correctly set both args

@rswanson
fix: build-args
08015a8 
fix: build-args

fix: build-args
@rswanson rswanson self-assigned this Mar 6, 2024
DaniPopes
DaniPopes approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed it's the same as the other fields

@rswanson rswanson enabled auto-merge March 6, 2024 17:38
@rswanson rswanson added this pull request to the merge queue Mar 6, 2024
Merged via the queue into main with commit 64854c1 Mar 6, 2024
27 checks passed
@rswanson rswanson deleted the swanny/hive-bugfix branch March 6, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees

@rswanson rswanson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rswanson @DaniPopes