Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

primitives/chain: dev chain support cancun upgrade #7033

Merged
merged 5 commits into from
Mar 11, 2024
Merged

primitives/chain: dev chain support cancun upgrade #7033

merged 5 commits into from
Mar 11, 2024

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Mar 7, 2024

Run node --dev support Cancun upgrade

mattsse
mattsse requested changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

crates/primitives/src/chain/spec.rs Show resolved Hide resolved
@mattsse mattsse marked this pull request as ready for review March 7, 2024 15:07
@mattsse mattsse requested a review from gakonst as a code owner March 7, 2024 15:07
@mattsse mattsse added the C-enhancement New feature or request label Mar 7, 2024
mattsse
mattsse previously approved these changes Mar 7, 2024
View reviewed changes
@mattsse mattsse dismissed their stale review March 7, 2024 23:09

missing checks

@jsvisa jsvisa requested a review from mattsse March 7, 2024 23:26
@jsvisa
Copy link
Contributor Author

jsvisa commented Mar 7, 2024 •
edited
Loading

Could you please take another look @mattsse . The blob blocks now can be successfully build, but the block’s blob gas used was not calculated(maybe i’ll file in another pr)

@mattsse mattsse self-assigned this Mar 9, 2024
@jsvisa
Copy link
Contributor Author

jsvisa commented Mar 11, 2024

@mattsse sorry to bother you, but is there anything more I need to adjust?

mattsse
mattsse approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mattsse mattsse added this pull request to the merge queue Mar 11, 2024
@mattsse mattsse removed this pull request from the merge queue due to a manual request Mar 11, 2024
@mattsse mattsse merged commit 66c9403 into paradigmxyz:main Mar 11, 2024
27 checks passed
@jsvisa jsvisa deleted the dev-node-cancun branch March 11, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@gakonst gakonst Awaiting requested review from gakonst

Assignees

@mattsse mattsse

Labels
C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jsvisa @mattsse