Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make clippy happy #7045

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Mar 8, 2024

error: assigning the result of `Clone::clone()` may be inefficient
   --> crates/primitives/src/revm/env.rs:288:13
    |
288 |             tx_env.blob_hashes = tx.blob_versioned_hashes.clone();
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `tx_env.blob_hashes.clone_from(&tx.blob_versioned_hashes)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
    = note: `-D clippy::assigning-clones` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::assigning_clones)]`

error: could not compile `reth-primitives` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
error: could not compile `reth-primitives` (lib test) due to 1 previous error
Error: Process completed with exit code 101.

@jsvisa jsvisa marked this pull request as ready for review March 8, 2024 07:10
@jsvisa jsvisa requested a review from gakonst as a code owner March 8, 2024 07:10
@jsvisa jsvisa requested a review from onbjerg as a code owner March 8, 2024 12:46
@DaniPopes DaniPopes changed the title primitives/revm: make clippy happy chore: make clippy happy Mar 8, 2024
@DaniPopes DaniPopes enabled auto-merge March 8, 2024 12:51
@DaniPopes DaniPopes added this pull request to the merge queue Mar 8, 2024
Merged via the queue into paradigmxyz:main with commit ed0dce8 Mar 8, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants