Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: replace BytesMut with alloy_rlp::encode #7047

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

estensen
Copy link
Contributor

@estensen estensen commented Mar 8, 2024

Ref #6986

Some issues running the tests locally

cargo test --workspace
...
     Running unittests src/lib.rs (target/debug/deps/reth_etl-9ce46664de48f371)

running 1 test
test tests::etl_hashes ... FAILED

failures:

---- tests::etl_hashes stdout ----
thread 'tests::etl_hashes' panicked at crates/etl/src/lib.rs:280:36:
called `Result::unwrap()` on an `Err` value: Custom { kind: Uncategorized, error: PathError { path: "/var/folders/qd/736ntn5d55d5l1c23gvwtgm40000gn/T/.tmpOTLFBA/.tmpBM6ObO", err: Os { code: 24, kind: Uncategorized, message: "Too many open files" } } }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    tests::etl_hashes

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.03s

Or is it sufficient to run cargo test (which passes) here? Pretty new with Rust.

@mattsse mattsse added the C-debt A section of code is hard to understand or change label Mar 8, 2024
@DaniPopes
Copy link
Member

DaniPopes commented Mar 8, 2024

You can target specific crates with -p package or reduce the number of threads executing with -j n, I would defer to CI anyway for running all tests

@DaniPopes DaniPopes requested review from DaniPopes and removed request for Rjected, gakonst, Evalir and emhane March 8, 2024 12:35
@DaniPopes DaniPopes enabled auto-merge March 8, 2024 13:48
@DaniPopes
Copy link
Member

I've removed 'fixes' because there are still calls, I would like for all of them to be removed.

@DaniPopes DaniPopes added this pull request to the merge queue Mar 8, 2024
Merged via the queue into paradigmxyz:main with commit 7fa3504 Mar 8, 2024
27 checks passed
@estensen estensen deleted the rlp-encode branch March 8, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt A section of code is hard to understand or change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants