chore: be less strict when slashing trusted peers #7052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
approved these changes
Mar 8, 2024
emhane
approved these changes
Mar 8, 2024
Comment on lines
+40
to
+45
| /// The maximum reputation change that can be applied to a trusted peer. | ||
| /// This is used to prevent a single bad message from a trusted peer to cause a significant change. | ||
| /// This gives a trusted peer more leeway when interacting with the node, which is useful for in | ||
| /// custom setups. By not setting this to `0` we still allow trusted peer penalization but less than | ||
| /// untrusted peers. | ||
| pub(crate) const MAX_TRUSTED_PEER_REPUTATION_CHANGE: Reputation = 2 * REPUTATION_UNIT; |
There was a problem hiding this comment.
isn't this rather a minimum since REPUTATION_UNIT is negative?
There was a problem hiding this comment.
it's negative, but it should act as the maximum reputation change we want to apply:
max(4 * Unit, MAX_TRUSTED_PEER_REPUTATION_CHANGE) == MAX_TRUSTED_PEER_REPUTATION_CHANGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #7037
This adds a check before applying a reputation change and prevents slashing of trusted peers for certain errors and is less strict when applying the reputation change
this could perhaps need a bit more tuning or even prevent banning of trusted peers entirely (will open an issue).