Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: more Vec over BytesMut #7084

Merged
merged 1 commit into from
Mar 11, 2024
Merged

chore: more Vec over BytesMut #7084

merged 1 commit into from
Mar 11, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Mar 10, 2024

more select Vec replacements ref #6986

@mattsse mattsse requested a review from DaniPopes March 10, 2024 11:21
@mattsse mattsse added the C-debt A section of code is hard to understand or change label Mar 10, 2024
@mattsse mattsse force-pushed the matt/more-vec-over-bytesmut branch from a768d37 to aacdccb Compare March 10, 2024 11:24
@mattsse mattsse force-pushed the matt/more-vec-over-bytesmut branch from aacdccb to 6d9b514 Compare March 10, 2024 11:27
emhane
emhane approved these changes Mar 10, 2024
View reviewed changes
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think there are some more places this can be done, hence agreed that this references the issue but doesn't close it. for example in Stream and Sink impl in eth-wire stream types.

@mattsse mattsse added this pull request to the merge queue Mar 11, 2024
Merged via the queue into main with commit 81291ff Mar 11, 2024
27 checks passed
@mattsse mattsse deleted the matt/more-vec-over-bytesmut branch March 11, 2024 13:01
@estensen estensen mentioned this pull request Mar 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@emhane emhane emhane approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
C-debt A section of code is hard to understand or change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattsse @DaniPopes @emhane