Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: loglevel value parser #8573

Merged
merged 10 commits into from
Jun 5, 2024
Merged

feature: loglevel value parser #8573

merged 10 commits into from
Jun 5, 2024

Conversation

JackG-eth
Copy link
Contributor

@JackG-eth JackG-eth commented Jun 3, 2024 •
edited
Loading

custom clap value parser for LogLevel enum

Motivation
remove clap feature from LogLevel: closes #8465

mattsse
mattsse requested changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, valueparser looks great

now we need to move this to node-core so we can actually get rid of the clap dep

crates/storage/errors/src/db.rs Outdated Show resolved Hide resolved
@JackG-eth JackG-eth requested a review from gakonst as a code owner June 3, 2024 22:10
mattsse
mattsse requested changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there

crates/node-core/src/args/database.rs Outdated Show resolved Hide resolved
crates/node-core/src/args/database.rs Outdated Show resolved Hide resolved
mattsse
mattsse approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@mattsse mattsse enabled auto-merge June 5, 2024 07:46
@mattsse mattsse added the A-cli Related to the reth CLI label Jun 5, 2024
@mattsse mattsse added this pull request to the merge queue Jun 5, 2024
Merged via the queue into paradigmxyz:main with commit 7e60bc4 Jun 5, 2024
30 checks passed
mw2000 pushed a commit to mw2000/reth that referenced this pull request Jun 5, 2024
@JackG-eth @mattsse @mw2000
feature: loglevel value parser (paradigmxyz#8573)
cb7c828 
Co-authored-by: Matthias Seitz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo

@shekhirin shekhirin Awaiting requested review from shekhirin

@Rjected Rjected Awaiting requested review from Rjected

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-cli Related to the reth CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove clap feature from LogLevel
2 participants
@JackG-eth @mattsse