Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make FullNodeComponents Clone #8966

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jun 19, 2024

makes the trait Clone by removing the impl from exex context and adding the trait functions as struct functions instead.

@mattsse mattsse added C-enhancement New feature or request A-exex Execution Extensions labels Jun 19, 2024
@mattsse mattsse force-pushed the matt/make-fullnode-components-clone branch from fc4ab85 to 18e608d Compare June 19, 2024 18:17
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ExExContext implementing node traits didn't make much sense to me

@mattsse mattsse enabled auto-merge June 19, 2024 18:18
@mattsse mattsse added this pull request to the merge queue Jun 19, 2024
Merged via the queue into main with commit 88dbb9b Jun 19, 2024
30 checks passed
@mattsse mattsse deleted the matt/make-fullnode-components-clone branch June 19, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-exex Execution Extensions C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants