Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: BackFillJobStream #9578

Merged
merged 6 commits into from
Jul 18, 2024
Merged

feat: BackFillJobStream #9578

merged 6 commits into from
Jul 18, 2024

Conversation

loocapro
Copy link
Contributor

Closes: #9179

mattsse
mattsse requested changes Jul 17, 2024
View reviewed changes
crates/exex/exex/src/backfill_stream.rs Outdated Show resolved Hide resolved
@loocapro loocapro marked this pull request as ready for review July 17, 2024 12:51
@loocapro loocapro requested a review from mattsse July 17, 2024 12:51
@shekhirin shekhirin added C-enhancement New feature or request A-exex Execution Extensions labels Jul 17, 2024
mattsse
mattsse requested changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few more nits, but this is pretty great!

crates/exex/exex/src/backfill/stream.rs Outdated Show resolved Hide resolved
crates/exex/exex/src/backfill/stream.rs Outdated Show resolved Hide resolved
crates/exex/exex/src/backfill/stream.rs Outdated Show resolved Hide resolved
crates/exex/exex/src/backfill/stream.rs Outdated Show resolved Hide resolved
@loocapro loocapro requested a review from mattsse July 18, 2024 08:14
shekhirin
shekhirin reviewed Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only nits, looks good!

crates/exex/exex/src/backfill/stream.rs Outdated Show resolved Hide resolved
crates/exex/exex/src/backfill/stream.rs Show resolved Hide resolved
@mattsse mattsse added this pull request to the merge queue Jul 18, 2024
Merged via the queue into paradigmxyz:main with commit 43ffb83 Jul 18, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-exex Execution Extensions C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stream wrapper type for iterators
3 participants
@loocapro @shekhirin @mattsse