Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(exex): move notification to types crate #9586

Merged
merged 2 commits into from
Jul 17, 2024
Merged

chore(exex): move notification to types crate #9586

merged 2 commits into from
Jul 17, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Jul 17, 2024 •
edited
Loading

ExExNotification belongs to reth-exex-types

@shekhirin shekhirin force-pushed the alexey/exex-notification-crate branch from bc95710 to 7c61692 Compare July 17, 2024 15:35
@shekhirin shekhirin force-pushed the alexey/exex-notification-crate branch from 3983ec5 to c64bcbe Compare July 17, 2024 15:50
@shekhirin shekhirin added C-debt Refactor of code section that is hard to understand or maintain A-exex Execution Extensions labels Jul 17, 2024
@shekhirin shekhirin marked this pull request as ready for review July 17, 2024 16:10
@shekhirin shekhirin requested a review from mattsse July 17, 2024 16:11
mattsse
mattsse approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@mattsse mattsse added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit bc4a167 Jul 17, 2024
33 checks passed
@mattsse mattsse deleted the alexey/exex-notification-crate branch July 17, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-exex Execution Extensions C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shekhirin @mattsse