-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add decoding for individual trace steps #157
Conversation
/// Represents a decoded internal function call. | ||
#[derive(Clone, Debug, PartialEq, Eq)] | ||
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] | ||
pub struct DecodedInternalCall { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe worth also adding an optional style field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't separate contract name and function name for internal calls, so I think func_name
can be styled directly?
I think this could be useful, though not sure how to deal with serde for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be a follow-up where we add it to other structs as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm,
pending @DaniPopes
ref foundry-rs/foundry#8222
ref foundry-rs/foundry#8198
Adds structs and extends
TraceWriter
to support formatting of decoded trace steps. Currently two decoding formats are supported:├─ [sload] <slot>
to trace. It might make sense to extend it to something more configurable once we start implementing this