Add extension to chain_spec_builder #4889
Open
+54
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Generally we should start with this: #4873 Maybe having like a separate command to add this could be useful. I mean I'm not a 100% fan of it, but it will make it easier for the users. |
|
Yeah that makes sense. I can either include a fix for that issue in this PR (left a comment on how to potentially fix it here), or push another PR to address it |
|
If you like, you can push it directly here. |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using with
polkadot-parachain, you usually need to specify therelay_chainandpara_idfields in the chain spec.A struct, called
Extensionsis introduced to the chain spec building processOne thing to consider is if we always want this extension present or if we wish to have a separate process for a parachain vs. a solo chain. I'm not sure how crucial the separation is here.
Also adds a fix for not overwriting the chain spec with the default config each time