rpc v2: submitAndWatch replace old messages if it's lagging
#4901
+387
−156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
commented
Jun 27, 2024
| stream.filter_map(move |event| async move { handle_event(event) }).boxed(); | ||
|
|
||
| // If the subscription is too slow older events will be overwritten. | ||
| sink.pipe_from_stream(stream.boxed(), RingBuffer::new(3)).await; |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
niklasad1
commented
Jun 28, 2024
substrate/client/rpc-spec-v2/src/transaction/tests/transaction_tests.rs
Outdated
Show resolved
Hide resolved
lexnv
reviewed
Jul 2, 2024
substrate/client/rpc/src/utils.rs
Outdated
| fn new() -> Self { | ||
| Self { inner: VecDeque::with_capacity(DEFAULT_BUF_SIZE), max_cap: DEFAULT_BUF_SIZE } | ||
| pub fn new(cap: usize) -> Self { | ||
| Self { inner: VecDeque::with_capacity(cap), max_cap: DEFAULT_BUF_SIZE } |
There was a problem hiding this comment.
Could the user pass a capacity higher than 16?
lexnv
reviewed
Jul 2, 2024
| .expect("Serialize infallible; qed") | ||
| /// Send a message on the subscription. | ||
| pub async fn send(&self, result: &impl Serialize) -> Result<(), DisconnectError> { | ||
| self.0.send(self.to_sub_message(result)).await |
There was a problem hiding this comment.
Nice! This makes the api easier to use!
niklasad1
commented
Jul 2, 2024
pkhry
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3076
The fix is really just that older messages are replaced if the client can't keep up with the server instead.
Because I wanted the same functionality as
pipe_from_streamfor both pending/subscription I added two wrapper types on-top of the types from jsonrpsee to make it nicer.I added a trait
Bufferso I could still use pipe_from_stream but that abstraction is a little leaky but only to avoid adding an identical method/function with another strategy...