Update PULL_REQUEST_TEMPLATE and CONTRIBUTING docs.
#4908
Conversation
kianenigma
added
the
R0-silent
| - [ ] My PR follows the [labeling requirements](CONTRIBUTING.md#Process) of this project (at minimum one label for `T` | ||
| required) | ||
| - [ ] My PR includes a detailed description as outlined in the "Description" and its two subsections above. | ||
| - [ ] My PR follows the [labeling requirements](CONTRIBUTING.md#Process) of this project (at minimum one label for `T` required) |
There was a problem hiding this comment.
External people can not do this or? So, this point is a little bit useless.
There was a problem hiding this comment.
Good point, yeah. Although, my hope is for us to be able to use the same doc for internal and external contibutors. So maybe we just prefix some points as "If you are a maintainer.."
Co-authored-by: Bastian Köcher <[email protected]>
docs/contributor/CONTRIBUTING.md
Outdated
| A Pull Request (PR) needs to be reviewed and approved by project maintainers. | ||
| If a change does not alter any logic (e.g. comments, dependencies, docs), then it may be tagged | ||
| * A Pull Request (PR) needs to be reviewed and approved by project maintainers. | ||
| * If a change does not alter any logic (e.g. comments, dependencies, docs), then it may be tagged | ||
| `A1-insubstantial` and merged faster. |
There was a problem hiding this comment.
| `A1-insubstantial` and merged faster. | |
| `R0-silent` and merged faster. |
There was a problem hiding this comment.
Is it though? I thought A1-insubstantial is still relevan. If not, we should delete it (among other useless labels).
There was a problem hiding this comment.
Hm okay, looks like either A1 or R0 are required: https://github.com/paritytech/labels/blob/d4b233298f6cc54dc9edc9f0432ca98a40ab20ef/ruled_labels/specs_polkadot-sdk.yaml#L165
But IMHO the overlap is pretty big, since every A1 can also be labeled R0. Maybe we should remove the A1.
No description provided.