This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Blocks carry full attestations for candidates #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
the
A3-in_progress
rphmeier
force-pushed
the
rh-full-attestations
branch
from
d31f222
to
a80157f
Compare
rphmeier
added
A0-please_review
gavofyork
reviewed
Nov 25, 2018
gavofyork
reviewed
Nov 25, 2018
gnunicorn
approved these changes
Nov 26, 2018
Co-Authored-By: rphmeier <[email protected]>
rphmeier
added
A8-looksgood
and removed
A0-please_review
tomusdrw
pushed a commit
that referenced
this pull request
Mar 26, 2021
tomusdrw
pushed a commit
that referenced
this pull request
Mar 26, 2021
* patch audit findings #42 * extend msg signature for substrate relay * signature verification test * make proof dependet on call_dispatch crate * silence clippy * revert deny exception * address code review * since it's not really a proof, call it digest
imstar15
pushed a commit
to imstar15/polkadot
that referenced
this pull request
Aug 25, 2021
) Fixes paritytech#34 Added .editorconfig
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #36
Closes #39
Previously, candidates were included raw in the
InherentDataand didn't carry with them the attestation data from validators. This is because before, in the instant finality consensus rules, validators would refuse to vote unless they had seen all candidates as fully-attested.Now that we are moving to non-instant finality with Aura/GRANDPA consensus, we have two options:
2 was significantly harder to implement. 1 may end up being expensive for now with lots of validators, since we have to check all the validity and availability statement signatures for each validator, but with BLS Signature Aggregation (#41) this will become
O(n)to the number of parachains.I needed a bit-vec implementation in the runtime to track which authorities had already voted, so I opened ferrilab/bitvec#3 to make one of the crates on
crates.iocompile forno-std.