This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
XCM V3 (Non-controversial Subset) #6564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawntabrizi
added
B0-silent
shawntabrizi
commented
Jan 17, 2023
Comment on lines
+182
to
+187
| if <Self as Store>::DownwardMessageQueues::decode_len(para).unwrap_or(0) > | ||
| MAX_MESSAGE_QUEUE_SIZE | ||
| { | ||
| return Err(QueueDownwardMessageError::ExceedsMaxMessageSize) | ||
| } | ||
|
|
There was a problem hiding this comment.
this might be the only logic change, but seems pretty uncontroversial
|
The relevant pr was already merged, so this isn't needed anymore |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce the diff of: #4097
This extracts trivial changes, and allows reviewers to focus on the more important details of the PR.
cumulus companion: paritytech/cumulus#2097