feat: add route /blocks/{blockId}/extrinsics/{extrinsicIndex} #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarikGul
changed the title
emostov
reviewed
Jan 21, 2021
dvdplm
suggested changes
Jan 22, 2021
src/services/test-helpers/responses/blocks/block789629Extrinsic.json
Outdated
Show resolved
Hide resolved
I agree |
Co-authored-by: Zeke Mostov <[email protected]>
Co-authored-by: Zeke Mostov <[email protected]>
Co-authored-by: Zeke Mostov <[email protected]>
fix: typos, naming, add parseNumberOrThrow fix: revert to parseInt
fix: cleanup block extrinsics controller fix: omitFinalized -> true fix: add test to check parseNumberOrThrow will throw an error if a negative is passed in. Yarn fix
fix: update extrinsic index test to query extrinsic 2 fix: lint
TarikGul
changed the title
dvdplm
approved these changes
Jan 25, 2021
dvdplm
reviewed
Jan 25, 2021
…/substrate-api-sidecar into extrinsics-controller
Co-authored-by: Zeke Mostov <[email protected]>
…/substrate-api-sidecar into extrinsics-controller
|
@TarikGul Thank you very much! |
|
@gutenye Of course, thank you for bringing up the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat
Added the route
/blocks/{blockId}/extrinsics/{extrinsicsIndex}Changelog
src/controllers/blocks/BlocksExtrinsicsController.tsAdded:
BlocksExtrinsicsController. This controller uses theBlocksServicein order to fetch the block, then retrieve the extrinsic.src/services/blocks/BlocksService.tsAdded:
fetchExtrinsicsByIndex. Fetch's the extrinsic that is requested in the params.src/services/blocks/BlocksService.spec.tsAdded a test 'describe' suite a called
fetchExrinsicsByIndex.Additionals:
Added mock data in:
src/services/test-helpers/responses/blocks/blocks789629Extrinsic.jsonNotes
Inside of the test suite, I had to reuse one line of code between 2 'it' statements. This is because jest was giving me issues with using async in a describe block. It treats it as a nested asynchronous function which will throw a unhandled promise, and abort the test or give inaccurate results.
closes #382