Remove more instances of futures01 #4633

expenses · 2020-01-15T16:16:51Z

Followup to #4447.

tomaka

tokio-rs/tokio#2118

client/service/src/lib.rs

This reverts commit 1c61728.

expenses · 2020-01-20T16:02:36Z

Grandpa tests are broken, but I'm gonna wait until #4612 to fix those.

expenses · 2020-01-21T11:24:23Z

The only remaining places where tokio and futures01 are used seem to be in rpc now.

tomaka · 2020-01-21T11:44:03Z

Heads-up: conflicts a bit with #4688. We can land either PR first, I don't care.

expenses · 2020-01-21T13:10:12Z

@tomaka No problem. I'd actually like to get #4612 merged first anyway.

Demi-Marie

Looks good if the testsuite passes.

Demi-Marie

The test suite needs to be ported over before it will compile.

didn’t check testsuite results

… into ashley-more-futures

client/network-gossip/Cargo.toml

client/network/test/Cargo.toml

tomaka · 2020-01-29T15:02:10Z

client/offchain/src/api/http.rs

-			});
-			(api, addr_rx.recv().unwrap())
-		}};
+	fn build_api_server() -> (HttpApi, SocketAddr) {


The original reason for using background threads is so that we wouldn't depend on being polled by tokio.

The tests seem to still be fine. Do you want. me to change it back to using background threads?

Considering that this crosses the "runtime boundary", it makes it less easy to figure out whether we're polling using tokio, so I'd say yes.

Tokio is annoyingly tricky, and I haven't figured out how to do this without getting a panic due to runtime stuff. I'll add a comment that should hopefully make things clearer though.

I just removed the offchain changes because I couldn't work out how net2 was getting pulled in and I would like to merge this PR soon. Probably caused by rust-lang/cargo#4866.

tomaka · 2020-01-29T15:04:17Z

client/service/test/src/lib.rs

@@ -75,12 +75,10 @@ impl<T> From<T> for SyncService<T> {
 }

 impl<T: futures::Future<Output=Result<(), sc_service::Error>> + Unpin> Future for SyncService<T> {


Not great to enforce Unpin, but since it's a test I don't really care.

expenses · 2020-01-30T15:59:46Z

According to the logs of RUST_LOG=sc_service_test=trace cargo test -p node-cli -- --ignored connectivity, test_connectivity is failing because the nodes in Checking linked topology aren't connecting:

[2020-01-30T15:48:46Z INFO  sc_service_test] Checking star topology
[2020-01-30T15:48:46Z INFO  sc_service_test] Full nodes ready: 0/5; Light nodes ready: 0/5
[2020-01-30T15:48:47Z INFO  sc_service_test] Full nodes ready: 0/5; Light nodes ready: 0/5
[2020-01-30T15:48:47Z INFO  sc_service_test] Full nodes ready: 0/5; Light nodes ready: 0/5
[2020-01-30T15:48:47Z INFO  sc_service_test] Full nodes ready: 1/5; Light nodes ready: 0/5
[2020-01-30T15:48:47Z INFO  sc_service_test] Full nodes ready: 1/5; Light nodes ready: 0/5
[2020-01-30T15:48:47Z INFO  sc_service_test] Full nodes ready: 1/5; Light nodes ready: 0/5
...
[2020-01-30T15:48:59Z INFO  sc_service_test] Full nodes ready: 4/5; Light nodes ready: 4/5
[2020-01-30T15:48:59Z INFO  sc_service_test] Full nodes ready: 5/5; Light nodes ready: 5/5
test chain_spec::tests::test_connectivity ... test chain_spec::tests::test_connectivity has been running for over 60 seconds
[2020-01-30T15:49:42Z INFO  sc_service_test] Checking linked topology
[2020-01-30T15:49:42Z INFO  sc_service_test] Full nodes ready: 0/5; Light nodes ready: 0/5
[2020-01-30T15:49:42Z INFO  sc_service_test] Full nodes ready: 0/5; Light nodes ready: 0/5
[2020-01-30T15:49:42Z INFO  sc_service_test] Full nodes ready: 0/5; Light nodes ready: 0/5
...
[2020-01-30T15:49:48Z INFO  sc_service_test] Full nodes ready: 0/5; Light nodes ready: 0/5

@tomaka any idea what might be happening here?

Demi-Marie

Something is pulling in hyper when compiling for wasm, which cannot possibly work.

Cargo.lock

expenses · 2020-02-10T15:17:00Z

Waiting on a new version of tokio due to tokio-rs/tokio#2186.

tomaka

I think that's an entirely backwards-compatible change.

* adding unleash to ci (#5020) * adding unleash to ci * fixing formatting * with a dot please * alpha.3 now * do not publish testing helpers * remove old test-helpers cruft * fix cargo.lock * with alpha 4 * do not publish runtime-interface-test either * disable more test crates from publishing * switch to alpha.5 * replace tempdir with tempfile * update lru * switch to bytes 0.5 * release script fixes * switch on and to latest alpha * BUT THE SPACES * Fix: CI failing for some CLI tests (#5043) * Initial commit Forked at: 41bb219 Parent branch: origin/master * Increase killing grace period of CLI tests and display more info * Use --dev everywhere possible * Put pruning mode to its own params struct * Add pruning params to export-blocks command * Added missing file * Removed not-dev mode in tests * Add pruning mode to the revert command * Decrease killing grace period again * Move back unsafe_pruning to import_params * Applied proposed changes * aura: remove unused tx pool (#5046) * aura: remove unused transaction pool parameter * node-template: remove transaction pool from aura * aura: fix tests * Extend rust nightly detection in `wasm-builder` (#5021) Instead of just testing `cargo` and `rustup run nightly`, we now test the `CARGO` env variable and also scan non default nightlies. The user is also now able to select the toolchain with `WASM_BUILD_TOOLCHAIN`. * Add steps setting to benchmarking CLI (#5033) * Add steps setting to CLI, use max value to hit worst case. * Bump impl_version. * Apply review suggestion. * Remove indices from node-template (#5025) * Remove indices from node-template * Use identity lookup instead * Bump impl * clean cargo.toml * Fix documentation for "BlockBuilder::push_trusted" (#5051) * fix doc * rephrase * do not check unleash on every PR, only master and tags (#5054) * do not check unleash on every PR, only master and tags * move scripts folder * add signed-tag check to CI * remove publish-to-crates-io dependencies Co-authored-by: s3krit <[email protected]> * prepare version to alpha.1 (#5055) bump version to -alpha.1 * Sync: validate block responses for required data (#5052) * Less verbose state-db logging * Validate block responses for block bodies * Update client/network/src/protocol.rs Co-Authored-By: Bastian Köcher <[email protected]> * Added validation test * Disconnect on missing header as well * Typo Co-Authored-By: André Silva <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: André Silva <[email protected]> * Make these chainspecs fields private (#5031) * Fix dockerfile (#5059) * Adds documentation for `wipe` and `commit` (#5053) * Adds documentation for `wipe` and `commit` This adds documentation to `wipe` and `commit` of `Externalities`. Besides that it removes the default implementation that would just panic and requires that all implementers of the trait implement the functions. * Update primitives/externalities/src/lib.rs Co-Authored-By: joe petrowski <[email protected]> Co-authored-by: joe petrowski <[email protected]> * Fix the issue with `trybuild`'s `ui` tests (#4992) * repro ui bug * fix the tests * test with the new image * test without CARGO_HOME * test without fixes * test again * fix trybuild old versions * bump CArgo.lock * fix trybuild newest versions * bump Cargo.lock * trying on the latest image * bump Cargo.lock * run with the old image * ci will be green on the image from 2020-02-19 [skip ci] * bump Cargo.lock * Activate publishing of draft releases... (#5062) * Activate publishing of draft releases... ... And fix the message sending (missing parameter). * publish_draft_release.sh now checks latest... ... release on github rather than just a tag * Fix/div by zero (#5041) * Handle gas_price being zero separately * Bump spec_version * Add a unit & integration tests for gas price = 0 * set missing metadata fields, prepping alpha.2 (#5067) * setting first batch of descriptions * fix what I just broke * next batch * and pallets, too * last batch * set cargo.lock * keep'em dev-deps * bump version to alpha.2 * Fix revalidation not revalidating multiple times (#5065) * removes use of sc_client::Client from sc_finality_grandpa (#5030) * removes use of sc_client::Client from sc_finality_grandpa * code formatting * code formatting * removes use of sc_client::Client from sc_finality_grandpa * Remove deprecated host functions (#5038) Sadly we need to keep one function `ext_blake2_256`. This function is manually defined in `sp-core`. * removes use of sc_client::Client from sc_basic_authorship (#5050) * removes use of sc-client from sc-basic-authorship * refactor use of ProposerFactory * correct dep path * pallet-transaction-payment clean up (#5070) * Formatting clean up * Introduce separate setters for the fees. * *: Rename prometheus-exporter crate to substrate-prometheus-end… (#5076) This patch renames the crate for the following two reasons: 1. The prometheus-exporter crate introduces native in-process Prometheus style instrumentation to the Substrate project. Within the Prometheus ecosystem the term "exporter" is used for external processes exposing metrics for e.g. the Linux Kernel. In-process exposition would be described via the term "endpoint". 2. "prometheus-exporter" is generic and ignores the fact that it is only usable within the context of Substrate. In addition the name "prometheus-exporter" is already taken on crates.io. * rename `browser-utils` to `substrate-browser-utils` (#5079) * prepping for Alpha.3 (#5080) * Bump to alpha.3 * update gitlab-ci * Propagate DispatchError for benchmarks. (#5075) * Propagate DispatchError for benchmarks. * Apply review suggestions. * Use RuntimeString. * fix expect Co-Authored-By: Bastian Köcher <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> * Add options to overwrite range bounds in benchmark command. (#5072) * Add --mins --maxs to benchmark command. * Apply review suggestions. * Update yamux to version 0.4.4. (#5086) * Remove more instances of futures01 (#4633) * Start removing last few instances of futures01 * Use to_poll on wasm * Revert "Use to_poll on wasm" This reverts commit 1c61728. * Fix fg test * Upgrade network test futures * Update offchain hyper version * Update service test * bump tokio to 0.2.10 * Removed some unneeded tokios * fixes * fix run_until_all_full * Make service test debuggable * Update client/offchain/src/api/http.rs Co-Authored-By: Demi Obenour <[email protected]> * Add service_test to test-int output * nitpicking * Finally fix test * Give up and revert client/serviec/test * Revert gitlab ci too Co-authored-by: Demi Obenour <[email protected]> * Make export blocks default to json on stdout (#5090) * Make export blocks default to json on stdout * Multiline instead of single line to stay under 100 cols * Change --json flag to --binary, defaulting to json * Offence reporting returns a result (#5082) * Offence reporting returns a result * Bump spec_version * Use unwrap instead of assertions * Fix more review grumbles * Update to libp2p 0.16.2 (#5088) * Remove request ID from the new protocol (#5049) * Make sure we remove a peer on disconnect in gossip (#5104) * Make sure we remove peers on disconnect in gossip state machine * Clear up the code * Add a comment * Expose `state-db` memory info (#5110) This exposes memory statistics from the state-db. * Change extrinsic_count to extrinsic_index in pallet-utility (#5044) Co-authored-by: Benjamin Kampmann <[email protected]> * Add more metrics to prometheus (#5034) * Add a few things * Add finality_grandpa_round * fix fg tests * Nitpicks * Nitpicks * Fix name of prometheus crate * Update to SCALE 1.2.0 (#5113) This updates `parity-scale-codec` to `1.2.0`, which includes multiple performance improvements and a fix that bounds the capacity of a vector at decoding. * Lazy payouts (#4474) * TODOs * Remove superfluous: * partial implementation * full implementation * fix preferences * update comments * upgrade test WIP * fix more tests * fix cutoff * fix saturation * comment * upgrade mock * upgrade test * WIP migration * WIP migration * remove slot stake stuff * fix merge * migration of ledger * remove equalize from test * add test * fix * update doc * fix compilation * improve test readibility * improve doc * fix most todo * fix migration and test * remove println * WIP * add test and spec * weight * update doc * safer end_era * fix exposure of conversion * Revert "safer end_era" This reverts commit 72ff737. * fix useless put * exposure clipped * doc * fix payout with clipped * fix node runtime * add doc * pluggable and generalized staking module * remove print * update doc * refactor * improve documentation and implementation * fix test * Fix test * fix test * fix test * fix remove lowest stake from exposure, not biggest. * nomination index arguments in nominator_payout * add test * try to fix offence * apply slashed and bond eras until active era * doc * update spec version * add test upgrade from previous test environment * Apply suggestions from code review Co-Authored-By: Shawn Tabrizi <[email protected]> * nominators upgrade has been cleaned * dynamic history depth implementation * make current_era - history_depth included * Change equality check to start era to less than or equal * Use era specific validator prefs * Add print statement and comment about start era if < * fix next_reward overflow * make more check for bad era claim for zero cost * small refactor * code refactor + fix use of deprecated storage * fix wasm build * add comment * Fix tests * remove outdated comment * Apply suggestions from code review Co-Authored-By: Shawn Tabrizi <[email protected]> * gather active era information into one storage Co-authored-by: thiolliere <[email protected]> Co-authored-by: Shawn Tabrizi <[email protected]> * impl on_runtime_upgrade Co-authored-by: Benjamin Kampmann <[email protected]> Co-authored-by: Cecile Tonglet <[email protected]> Co-authored-by: André Silva <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Marcio Diaz <[email protected]> Co-authored-by: Nikolay Volf <[email protected]> Co-authored-by: s3krit <[email protected]> Co-authored-by: Arkadiy Paronyan <[email protected]> Co-authored-by: Pierre Krieger <[email protected]> Co-authored-by: Chevdor <[email protected]> Co-authored-by: joe petrowski <[email protected]> Co-authored-by: Denis Pisarev <[email protected]> Co-authored-by: Eric <[email protected]> Co-authored-by: Seun Lanlege <[email protected]> Co-authored-by: Sergei Pepyakin <[email protected]> Co-authored-by: Max Inden <[email protected]> Co-authored-by: Ashley <[email protected]> Co-authored-by: Toralf Wittner <[email protected]> Co-authored-by: Demi Obenour <[email protected]> Co-authored-by: pscott <[email protected]> Co-authored-by: Fedor Sakharov <[email protected]> Co-authored-by: Gavin Wood <[email protected]> Co-authored-by: thiolliere <[email protected]>

* Start removing last few instances of futures01 * Use to_poll on wasm * Revert "Use to_poll on wasm" This reverts commit 1c61728. * Fix fg test * Upgrade network test futures * Update offchain hyper version * Update service test * bump tokio to 0.2.10 * Removed some unneeded tokios * fixes * fix run_until_all_full * Make service test debuggable * Update client/offchain/src/api/http.rs Co-Authored-By: Demi Obenour <[email protected]> * Add service_test to test-int output * nitpicking * Finally fix test * Give up and revert client/serviec/test * Revert gitlab ci too Co-authored-by: Demi Obenour <[email protected]>

* Initial idea of `on_runtime_upgrade` * Runtime storage for module version * Gui shawntabrizi runtime upgrade (#5118) * adding unleash to ci (#5020) * adding unleash to ci * fixing formatting * with a dot please * alpha.3 now * do not publish testing helpers * remove old test-helpers cruft * fix cargo.lock * with alpha 4 * do not publish runtime-interface-test either * disable more test crates from publishing * switch to alpha.5 * replace tempdir with tempfile * update lru * switch to bytes 0.5 * release script fixes * switch on and to latest alpha * BUT THE SPACES * Fix: CI failing for some CLI tests (#5043) * Initial commit Forked at: 41bb219 Parent branch: origin/master * Increase killing grace period of CLI tests and display more info * Use --dev everywhere possible * Put pruning mode to its own params struct * Add pruning params to export-blocks command * Added missing file * Removed not-dev mode in tests * Add pruning mode to the revert command * Decrease killing grace period again * Move back unsafe_pruning to import_params * Applied proposed changes * aura: remove unused tx pool (#5046) * aura: remove unused transaction pool parameter * node-template: remove transaction pool from aura * aura: fix tests * Extend rust nightly detection in `wasm-builder` (#5021) Instead of just testing `cargo` and `rustup run nightly`, we now test the `CARGO` env variable and also scan non default nightlies. The user is also now able to select the toolchain with `WASM_BUILD_TOOLCHAIN`. * Add steps setting to benchmarking CLI (#5033) * Add steps setting to CLI, use max value to hit worst case. * Bump impl_version. * Apply review suggestion. * Remove indices from node-template (#5025) * Remove indices from node-template * Use identity lookup instead * Bump impl * clean cargo.toml * Fix documentation for "BlockBuilder::push_trusted" (#5051) * fix doc * rephrase * do not check unleash on every PR, only master and tags (#5054) * do not check unleash on every PR, only master and tags * move scripts folder * add signed-tag check to CI * remove publish-to-crates-io dependencies Co-authored-by: s3krit <[email protected]> * prepare version to alpha.1 (#5055) bump version to -alpha.1 * Sync: validate block responses for required data (#5052) * Less verbose state-db logging * Validate block responses for block bodies * Update client/network/src/protocol.rs Co-Authored-By: Bastian Köcher <[email protected]> * Added validation test * Disconnect on missing header as well * Typo Co-Authored-By: André Silva <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: André Silva <[email protected]> * Make these chainspecs fields private (#5031) * Fix dockerfile (#5059) * Adds documentation for `wipe` and `commit` (#5053) * Adds documentation for `wipe` and `commit` This adds documentation to `wipe` and `commit` of `Externalities`. Besides that it removes the default implementation that would just panic and requires that all implementers of the trait implement the functions. * Update primitives/externalities/src/lib.rs Co-Authored-By: joe petrowski <[email protected]> Co-authored-by: joe petrowski <[email protected]> * Fix the issue with `trybuild`'s `ui` tests (#4992) * repro ui bug * fix the tests * test with the new image * test without CARGO_HOME * test without fixes * test again * fix trybuild old versions * bump CArgo.lock * fix trybuild newest versions * bump Cargo.lock * trying on the latest image * bump Cargo.lock * run with the old image * ci will be green on the image from 2020-02-19 [skip ci] * bump Cargo.lock * Activate publishing of draft releases... (#5062) * Activate publishing of draft releases... ... And fix the message sending (missing parameter). * publish_draft_release.sh now checks latest... ... release on github rather than just a tag * Fix/div by zero (#5041) * Handle gas_price being zero separately * Bump spec_version * Add a unit & integration tests for gas price = 0 * set missing metadata fields, prepping alpha.2 (#5067) * setting first batch of descriptions * fix what I just broke * next batch * and pallets, too * last batch * set cargo.lock * keep'em dev-deps * bump version to alpha.2 * Fix revalidation not revalidating multiple times (#5065) * removes use of sc_client::Client from sc_finality_grandpa (#5030) * removes use of sc_client::Client from sc_finality_grandpa * code formatting * code formatting * removes use of sc_client::Client from sc_finality_grandpa * Remove deprecated host functions (#5038) Sadly we need to keep one function `ext_blake2_256`. This function is manually defined in `sp-core`. * removes use of sc_client::Client from sc_basic_authorship (#5050) * removes use of sc-client from sc-basic-authorship * refactor use of ProposerFactory * correct dep path * pallet-transaction-payment clean up (#5070) * Formatting clean up * Introduce separate setters for the fees. * *: Rename prometheus-exporter crate to substrate-prometheus-end… (#5076) This patch renames the crate for the following two reasons: 1. The prometheus-exporter crate introduces native in-process Prometheus style instrumentation to the Substrate project. Within the Prometheus ecosystem the term "exporter" is used for external processes exposing metrics for e.g. the Linux Kernel. In-process exposition would be described via the term "endpoint". 2. "prometheus-exporter" is generic and ignores the fact that it is only usable within the context of Substrate. In addition the name "prometheus-exporter" is already taken on crates.io. * rename `browser-utils` to `substrate-browser-utils` (#5079) * prepping for Alpha.3 (#5080) * Bump to alpha.3 * update gitlab-ci * Propagate DispatchError for benchmarks. (#5075) * Propagate DispatchError for benchmarks. * Apply review suggestions. * Use RuntimeString. * fix expect Co-Authored-By: Bastian Köcher <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> * Add options to overwrite range bounds in benchmark command. (#5072) * Add --mins --maxs to benchmark command. * Apply review suggestions. * Update yamux to version 0.4.4. (#5086) * Remove more instances of futures01 (#4633) * Start removing last few instances of futures01 * Use to_poll on wasm * Revert "Use to_poll on wasm" This reverts commit 1c61728. * Fix fg test * Upgrade network test futures * Update offchain hyper version * Update service test * bump tokio to 0.2.10 * Removed some unneeded tokios * fixes * fix run_until_all_full * Make service test debuggable * Update client/offchain/src/api/http.rs Co-Authored-By: Demi Obenour <[email protected]> * Add service_test to test-int output * nitpicking * Finally fix test * Give up and revert client/serviec/test * Revert gitlab ci too Co-authored-by: Demi Obenour <[email protected]> * Make export blocks default to json on stdout (#5090) * Make export blocks default to json on stdout * Multiline instead of single line to stay under 100 cols * Change --json flag to --binary, defaulting to json * Offence reporting returns a result (#5082) * Offence reporting returns a result * Bump spec_version * Use unwrap instead of assertions * Fix more review grumbles * Update to libp2p 0.16.2 (#5088) * Remove request ID from the new protocol (#5049) * Make sure we remove a peer on disconnect in gossip (#5104) * Make sure we remove peers on disconnect in gossip state machine * Clear up the code * Add a comment * Expose `state-db` memory info (#5110) This exposes memory statistics from the state-db. * Change extrinsic_count to extrinsic_index in pallet-utility (#5044) Co-authored-by: Benjamin Kampmann <[email protected]> * Add more metrics to prometheus (#5034) * Add a few things * Add finality_grandpa_round * fix fg tests * Nitpicks * Nitpicks * Fix name of prometheus crate * Update to SCALE 1.2.0 (#5113) This updates `parity-scale-codec` to `1.2.0`, which includes multiple performance improvements and a fix that bounds the capacity of a vector at decoding. * Lazy payouts (#4474) * TODOs * Remove superfluous: * partial implementation * full implementation * fix preferences * update comments * upgrade test WIP * fix more tests * fix cutoff * fix saturation * comment * upgrade mock * upgrade test * WIP migration * WIP migration * remove slot stake stuff * fix merge * migration of ledger * remove equalize from test * add test * fix * update doc * fix compilation * improve test readibility * improve doc * fix most todo * fix migration and test * remove println * WIP * add test and spec * weight * update doc * safer end_era * fix exposure of conversion * Revert "safer end_era" This reverts commit 72ff737. * fix useless put * exposure clipped * doc * fix payout with clipped * fix node runtime * add doc * pluggable and generalized staking module * remove print * update doc * refactor * improve documentation and implementation * fix test * Fix test * fix test * fix test * fix remove lowest stake from exposure, not biggest. * nomination index arguments in nominator_payout * add test * try to fix offence * apply slashed and bond eras until active era * doc * update spec version * add test upgrade from previous test environment * Apply suggestions from code review Co-Authored-By: Shawn Tabrizi <[email protected]> * nominators upgrade has been cleaned * dynamic history depth implementation * make current_era - history_depth included * Change equality check to start era to less than or equal * Use era specific validator prefs * Add print statement and comment about start era if < * fix next_reward overflow * make more check for bad era claim for zero cost * small refactor * code refactor + fix use of deprecated storage * fix wasm build * add comment * Fix tests * remove outdated comment * Apply suggestions from code review Co-Authored-By: Shawn Tabrizi <[email protected]> * gather active era information into one storage Co-authored-by: thiolliere <[email protected]> Co-authored-by: Shawn Tabrizi <[email protected]> * impl on_runtime_upgrade Co-authored-by: Benjamin Kampmann <[email protected]> Co-authored-by: Cecile Tonglet <[email protected]> Co-authored-by: André Silva <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Marcio Diaz <[email protected]> Co-authored-by: Nikolay Volf <[email protected]> Co-authored-by: s3krit <[email protected]> Co-authored-by: Arkadiy Paronyan <[email protected]> Co-authored-by: Pierre Krieger <[email protected]> Co-authored-by: Chevdor <[email protected]> Co-authored-by: joe petrowski <[email protected]> Co-authored-by: Denis Pisarev <[email protected]> Co-authored-by: Eric <[email protected]> Co-authored-by: Seun Lanlege <[email protected]> Co-authored-by: Sergei Pepyakin <[email protected]> Co-authored-by: Max Inden <[email protected]> Co-authored-by: Ashley <[email protected]> Co-authored-by: Toralf Wittner <[email protected]> Co-authored-by: Demi Obenour <[email protected]> Co-authored-by: pscott <[email protected]> Co-authored-by: Fedor Sakharov <[email protected]> Co-authored-by: Gavin Wood <[email protected]> Co-authored-by: thiolliere <[email protected]> * make compile * Add some tests * docs * Remove "useless" code * Fix merge and use n + 1 block number * Fix tests * unfix ui tests * Update on_initialize.stderr * fix test * Fix test * Bump spec * Remove `on_finalise` and `on_initialise` * Use bool for tracking runtime upgraded * typo * Support runtime upgrade with `set_storage` * Refactor migration code location * add trailing newlines * Remove old `IsUpgraded` flag * Update state root * Exhaustive match statement * Apply suggestions from code review Co-Authored-By: Kian Paimani <[email protected]> Co-authored-by: Benjamin Kampmann <[email protected]> Co-authored-by: Cecile Tonglet <[email protected]> Co-authored-by: André Silva <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Marcio Diaz <[email protected]> Co-authored-by: Nikolay Volf <[email protected]> Co-authored-by: s3krit <[email protected]> Co-authored-by: Arkadiy Paronyan <[email protected]> Co-authored-by: Pierre Krieger <[email protected]> Co-authored-by: Chevdor <[email protected]> Co-authored-by: joe petrowski <[email protected]> Co-authored-by: Denis Pisarev <[email protected]> Co-authored-by: Eric <[email protected]> Co-authored-by: Seun Lanlege <[email protected]> Co-authored-by: Sergei Pepyakin <[email protected]> Co-authored-by: Max Inden <[email protected]> Co-authored-by: Ashley <[email protected]> Co-authored-by: Toralf Wittner <[email protected]> Co-authored-by: Demi Obenour <[email protected]> Co-authored-by: pscott <[email protected]> Co-authored-by: Fedor Sakharov <[email protected]> Co-authored-by: Gavin Wood <[email protected]> Co-authored-by: thiolliere <[email protected]> Co-authored-by: Kian Paimani <[email protected]>

* Initial idea of `on_runtime_upgrade` * Runtime storage for module version * Gui shawntabrizi runtime upgrade (paritytech#5118) * adding unleash to ci (paritytech#5020) * adding unleash to ci * fixing formatting * with a dot please * alpha.3 now * do not publish testing helpers * remove old test-helpers cruft * fix cargo.lock * with alpha 4 * do not publish runtime-interface-test either * disable more test crates from publishing * switch to alpha.5 * replace tempdir with tempfile * update lru * switch to bytes 0.5 * release script fixes * switch on and to latest alpha * BUT THE SPACES * Fix: CI failing for some CLI tests (paritytech#5043) * Initial commit Forked at: 41bb219 Parent branch: origin/master * Increase killing grace period of CLI tests and display more info * Use --dev everywhere possible * Put pruning mode to its own params struct * Add pruning params to export-blocks command * Added missing file * Removed not-dev mode in tests * Add pruning mode to the revert command * Decrease killing grace period again * Move back unsafe_pruning to import_params * Applied proposed changes * aura: remove unused tx pool (paritytech#5046) * aura: remove unused transaction pool parameter * node-template: remove transaction pool from aura * aura: fix tests * Extend rust nightly detection in `wasm-builder` (paritytech#5021) Instead of just testing `cargo` and `rustup run nightly`, we now test the `CARGO` env variable and also scan non default nightlies. The user is also now able to select the toolchain with `WASM_BUILD_TOOLCHAIN`. * Add steps setting to benchmarking CLI (paritytech#5033) * Add steps setting to CLI, use max value to hit worst case. * Bump impl_version. * Apply review suggestion. * Remove indices from node-template (paritytech#5025) * Remove indices from node-template * Use identity lookup instead * Bump impl * clean cargo.toml * Fix documentation for "BlockBuilder::push_trusted" (paritytech#5051) * fix doc * rephrase * do not check unleash on every PR, only master and tags (paritytech#5054) * do not check unleash on every PR, only master and tags * move scripts folder * add signed-tag check to CI * remove publish-to-crates-io dependencies Co-authored-by: s3krit <[email protected]> * prepare version to alpha.1 (paritytech#5055) bump version to -alpha.1 * Sync: validate block responses for required data (paritytech#5052) * Less verbose state-db logging * Validate block responses for block bodies * Update client/network/src/protocol.rs Co-Authored-By: Bastian Köcher <[email protected]> * Added validation test * Disconnect on missing header as well * Typo Co-Authored-By: André Silva <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: André Silva <[email protected]> * Make these chainspecs fields private (paritytech#5031) * Fix dockerfile (paritytech#5059) * Adds documentation for `wipe` and `commit` (paritytech#5053) * Adds documentation for `wipe` and `commit` This adds documentation to `wipe` and `commit` of `Externalities`. Besides that it removes the default implementation that would just panic and requires that all implementers of the trait implement the functions. * Update primitives/externalities/src/lib.rs Co-Authored-By: joe petrowski <[email protected]> Co-authored-by: joe petrowski <[email protected]> * Fix the issue with `trybuild`'s `ui` tests (paritytech#4992) * repro ui bug * fix the tests * test with the new image * test without CARGO_HOME * test without fixes * test again * fix trybuild old versions * bump CArgo.lock * fix trybuild newest versions * bump Cargo.lock * trying on the latest image * bump Cargo.lock * run with the old image * ci will be green on the image from 2020-02-19 [skip ci] * bump Cargo.lock * Activate publishing of draft releases... (paritytech#5062) * Activate publishing of draft releases... ... And fix the message sending (missing parameter). * publish_draft_release.sh now checks latest... ... release on github rather than just a tag * Fix/div by zero (paritytech#5041) * Handle gas_price being zero separately * Bump spec_version * Add a unit & integration tests for gas price = 0 * set missing metadata fields, prepping alpha.2 (paritytech#5067) * setting first batch of descriptions * fix what I just broke * next batch * and pallets, too * last batch * set cargo.lock * keep'em dev-deps * bump version to alpha.2 * Fix revalidation not revalidating multiple times (paritytech#5065) * removes use of sc_client::Client from sc_finality_grandpa (paritytech#5030) * removes use of sc_client::Client from sc_finality_grandpa * code formatting * code formatting * removes use of sc_client::Client from sc_finality_grandpa * Remove deprecated host functions (paritytech#5038) Sadly we need to keep one function `ext_blake2_256`. This function is manually defined in `sp-core`. * removes use of sc_client::Client from sc_basic_authorship (paritytech#5050) * removes use of sc-client from sc-basic-authorship * refactor use of ProposerFactory * correct dep path * pallet-transaction-payment clean up (paritytech#5070) * Formatting clean up * Introduce separate setters for the fees. * *: Rename prometheus-exporter crate to substrate-prometheus-end… (paritytech#5076) This patch renames the crate for the following two reasons: 1. The prometheus-exporter crate introduces native in-process Prometheus style instrumentation to the Substrate project. Within the Prometheus ecosystem the term "exporter" is used for external processes exposing metrics for e.g. the Linux Kernel. In-process exposition would be described via the term "endpoint". 2. "prometheus-exporter" is generic and ignores the fact that it is only usable within the context of Substrate. In addition the name "prometheus-exporter" is already taken on crates.io. * rename `browser-utils` to `substrate-browser-utils` (paritytech#5079) * prepping for Alpha.3 (paritytech#5080) * Bump to alpha.3 * update gitlab-ci * Propagate DispatchError for benchmarks. (paritytech#5075) * Propagate DispatchError for benchmarks. * Apply review suggestions. * Use RuntimeString. * fix expect Co-Authored-By: Bastian Köcher <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> * Add options to overwrite range bounds in benchmark command. (paritytech#5072) * Add --mins --maxs to benchmark command. * Apply review suggestions. * Update yamux to version 0.4.4. (paritytech#5086) * Remove more instances of futures01 (paritytech#4633) * Start removing last few instances of futures01 * Use to_poll on wasm * Revert "Use to_poll on wasm" This reverts commit 1c61728. * Fix fg test * Upgrade network test futures * Update offchain hyper version * Update service test * bump tokio to 0.2.10 * Removed some unneeded tokios * fixes * fix run_until_all_full * Make service test debuggable * Update client/offchain/src/api/http.rs Co-Authored-By: Demi Obenour <[email protected]> * Add service_test to test-int output * nitpicking * Finally fix test * Give up and revert client/serviec/test * Revert gitlab ci too Co-authored-by: Demi Obenour <[email protected]> * Make export blocks default to json on stdout (paritytech#5090) * Make export blocks default to json on stdout * Multiline instead of single line to stay under 100 cols * Change --json flag to --binary, defaulting to json * Offence reporting returns a result (paritytech#5082) * Offence reporting returns a result * Bump spec_version * Use unwrap instead of assertions * Fix more review grumbles * Update to libp2p 0.16.2 (paritytech#5088) * Remove request ID from the new protocol (paritytech#5049) * Make sure we remove a peer on disconnect in gossip (paritytech#5104) * Make sure we remove peers on disconnect in gossip state machine * Clear up the code * Add a comment * Expose `state-db` memory info (paritytech#5110) This exposes memory statistics from the state-db. * Change extrinsic_count to extrinsic_index in pallet-utility (paritytech#5044) Co-authored-by: Benjamin Kampmann <[email protected]> * Add more metrics to prometheus (paritytech#5034) * Add a few things * Add finality_grandpa_round * fix fg tests * Nitpicks * Nitpicks * Fix name of prometheus crate * Update to SCALE 1.2.0 (paritytech#5113) This updates `parity-scale-codec` to `1.2.0`, which includes multiple performance improvements and a fix that bounds the capacity of a vector at decoding. * Lazy payouts (paritytech#4474) * TODOs * Remove superfluous: * partial implementation * full implementation * fix preferences * update comments * upgrade test WIP * fix more tests * fix cutoff * fix saturation * comment * upgrade mock * upgrade test * WIP migration * WIP migration * remove slot stake stuff * fix merge * migration of ledger * remove equalize from test * add test * fix * update doc * fix compilation * improve test readibility * improve doc * fix most todo * fix migration and test * remove println * WIP * add test and spec * weight * update doc * safer end_era * fix exposure of conversion * Revert "safer end_era" This reverts commit 72ff737. * fix useless put * exposure clipped * doc * fix payout with clipped * fix node runtime * add doc * pluggable and generalized staking module * remove print * update doc * refactor * improve documentation and implementation * fix test * Fix test * fix test * fix test * fix remove lowest stake from exposure, not biggest. * nomination index arguments in nominator_payout * add test * try to fix offence * apply slashed and bond eras until active era * doc * update spec version * add test upgrade from previous test environment * Apply suggestions from code review Co-Authored-By: Shawn Tabrizi <[email protected]> * nominators upgrade has been cleaned * dynamic history depth implementation * make current_era - history_depth included * Change equality check to start era to less than or equal * Use era specific validator prefs * Add print statement and comment about start era if < * fix next_reward overflow * make more check for bad era claim for zero cost * small refactor * code refactor + fix use of deprecated storage * fix wasm build * add comment * Fix tests * remove outdated comment * Apply suggestions from code review Co-Authored-By: Shawn Tabrizi <[email protected]> * gather active era information into one storage Co-authored-by: thiolliere <[email protected]> Co-authored-by: Shawn Tabrizi <[email protected]> * impl on_runtime_upgrade Co-authored-by: Benjamin Kampmann <[email protected]> Co-authored-by: Cecile Tonglet <[email protected]> Co-authored-by: André Silva <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Marcio Diaz <[email protected]> Co-authored-by: Nikolay Volf <[email protected]> Co-authored-by: s3krit <[email protected]> Co-authored-by: Arkadiy Paronyan <[email protected]> Co-authored-by: Pierre Krieger <[email protected]> Co-authored-by: Chevdor <[email protected]> Co-authored-by: joe petrowski <[email protected]> Co-authored-by: Denis Pisarev <[email protected]> Co-authored-by: Eric <[email protected]> Co-authored-by: Seun Lanlege <[email protected]> Co-authored-by: Sergei Pepyakin <[email protected]> Co-authored-by: Max Inden <[email protected]> Co-authored-by: Ashley <[email protected]> Co-authored-by: Toralf Wittner <[email protected]> Co-authored-by: Demi Obenour <[email protected]> Co-authored-by: pscott <[email protected]> Co-authored-by: Fedor Sakharov <[email protected]> Co-authored-by: Gavin Wood <[email protected]> Co-authored-by: thiolliere <[email protected]> * make compile * Add some tests * docs * Remove "useless" code * Fix merge and use n + 1 block number * Fix tests * unfix ui tests * Update on_initialize.stderr * fix test * Fix test * Bump spec * Remove `on_finalise` and `on_initialise` * Use bool for tracking runtime upgraded * typo * Support runtime upgrade with `set_storage` * Refactor migration code location * add trailing newlines * Remove old `IsUpgraded` flag * Update state root * Exhaustive match statement * Apply suggestions from code review Co-Authored-By: Kian Paimani <[email protected]> Co-authored-by: Benjamin Kampmann <[email protected]> Co-authored-by: Cecile Tonglet <[email protected]> Co-authored-by: André Silva <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Marcio Diaz <[email protected]> Co-authored-by: Nikolay Volf <[email protected]> Co-authored-by: s3krit <[email protected]> Co-authored-by: Arkadiy Paronyan <[email protected]> Co-authored-by: Pierre Krieger <[email protected]> Co-authored-by: Chevdor <[email protected]> Co-authored-by: joe petrowski <[email protected]> Co-authored-by: Denis Pisarev <[email protected]> Co-authored-by: Eric <[email protected]> Co-authored-by: Seun Lanlege <[email protected]> Co-authored-by: Sergei Pepyakin <[email protected]> Co-authored-by: Max Inden <[email protected]> Co-authored-by: Ashley <[email protected]> Co-authored-by: Toralf Wittner <[email protected]> Co-authored-by: Demi Obenour <[email protected]> Co-authored-by: pscott <[email protected]> Co-authored-by: Fedor Sakharov <[email protected]> Co-authored-by: Gavin Wood <[email protected]> Co-authored-by: thiolliere <[email protected]> Co-authored-by: Kian Paimani <[email protected]>

Start removing last few instances of futures01

8da9a8a

expenses requested a review from tomaka January 15, 2020 16:16

tomaka reviewed Jan 15, 2020

View reviewed changes

client/service/src/lib.rs Outdated Show resolved Hide resolved

expenses added the A3-in_progress Pull request is in progress. No review needed at this stage. label Jan 15, 2020

expenses added 5 commits January 15, 2020 20:12

Use to_poll on wasm

1c61728

Revert "Use to_poll on wasm"

8f42407

This reverts commit 1c61728.

Fix fg test

a80cc31

Upgrade network test futures

66f837a

Update offchain hyper version

4e9e5c6

Update service test

7a429c6

expenses marked this pull request as ready for review January 21, 2020 11:24

expenses requested review from andresilva, Demi-Marie and tomusdrw as code owners January 21, 2020 11:24

Merge remote-tracking branch 'parity/master' into ashley-more-futures

738fff9

Merge remote-tracking branch 'parity/master' into ashley-more-futures

19c8b38

mxinden mentioned this pull request Jan 22, 2020

client/finality-grandpa: Make round_communication use bounded channel #4691

Merged

expenses mentioned this pull request Jan 23, 2020

Switch GrandPa to std futures (replaces #3909) #4612

Merged

expenses added 2 commits January 24, 2020 15:02

Merge remote-tracking branch 'parity/master' into ashley-more-futures

5d36bef

bump tokio to 0.2.10

9a196df

expenses removed the A3-in_progress Pull request is in progress. No review needed at this stage. label Jan 24, 2020

Removed some unneeded tokios

29b70b8

Demi-Marie previously approved these changes Jan 24, 2020

View reviewed changes

Demi-Marie self-requested a review January 24, 2020 21:32

Demi-Marie reviewed Jan 24, 2020

View reviewed changes

Merge branch 'ashley-more-futures' of github.com:paritytech/substrate…

25f1579

… into ashley-more-futures

tomaka approved these changes Jan 29, 2020

View reviewed changes

expenses added 2 commits January 30, 2020 16:10

Merge remote-tracking branch 'parity/master' into ashley-more-futures

a0d4b37

nitpicking

4270f7f

Demi-Marie suggested changes Feb 2, 2020

View reviewed changes

Cargo.lock Outdated Show resolved Hide resolved

expenses added 3 commits February 6, 2020 14:01

Merge remote-tracking branch 'parity/master' into HEAD

b5e8f13

Finally fix test

64856fe

Merge remote-tracking branch 'parity/master' into ashley-more-futures

18fe65a

expenses requested a review from Demi-Marie February 10, 2020 15:17

expenses added the A1-onice label Feb 10, 2020

expenses mentioned this pull request Feb 20, 2020

Clean up the public API of sc-network-gossip #5001

Merged

expenses added 4 commits February 27, 2020 22:24

Merge remote-tracking branch 'parity/master' into ashley-more-futures

6eb50f6

Give up and revert client/serviec/test

bcc5b8b

Revert gitlab ci too

53c4ccf

Merge remote-tracking branch 'parity/master' into ashley-more-futures

143d62e

tomaka approved these changes Feb 28, 2020

View reviewed changes

expenses added A8-looksgood B0-silent Changes should not be mentioned in any release notes and removed A1-onice labels Feb 28, 2020

expenses added this to the 2.0 milestone Feb 28, 2020

gnunicorn merged commit 29cee59 into master Feb 28, 2020

gnunicorn deleted the ashley-more-futures branch February 28, 2020 16:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove more instances of futures01 #4633

Remove more instances of futures01 #4633

expenses commented Jan 15, 2020

tomaka left a comment

expenses commented Jan 20, 2020

expenses commented Jan 21, 2020

tomaka commented Jan 21, 2020

expenses commented Jan 21, 2020

Demi-Marie left a comment

Demi-Marie left a comment

tomaka Jan 29, 2020

expenses Jan 30, 2020

tomaka Feb 3, 2020

expenses Feb 5, 2020

expenses Feb 6, 2020

tomaka Jan 29, 2020

expenses commented Jan 30, 2020

Demi-Marie left a comment

expenses commented Feb 10, 2020

tomaka left a comment

		@@ -75,12 +75,10 @@ impl<T> From<T> for SyncService<T> {
		}

		impl<T: futures::Future<Output=Result<(), sc_service::Error>> + Unpin> Future for SyncService<T> {

Remove more instances of futures01 #4633

Remove more instances of futures01 #4633

Conversation

expenses commented Jan 15, 2020

tomaka left a comment

Choose a reason for hiding this comment

expenses commented Jan 20, 2020

expenses commented Jan 21, 2020

tomaka commented Jan 21, 2020

expenses commented Jan 21, 2020

Demi-Marie left a comment

Choose a reason for hiding this comment

Demi-Marie left a comment

Choose a reason for hiding this comment

tomaka Jan 29, 2020

Choose a reason for hiding this comment

expenses Jan 30, 2020

Choose a reason for hiding this comment

tomaka Feb 3, 2020

Choose a reason for hiding this comment

expenses Feb 5, 2020

Choose a reason for hiding this comment

expenses Feb 6, 2020

Choose a reason for hiding this comment

tomaka Jan 29, 2020

Choose a reason for hiding this comment

expenses commented Jan 30, 2020

Demi-Marie left a comment

Choose a reason for hiding this comment

expenses commented Feb 10, 2020

tomaka left a comment

Choose a reason for hiding this comment