Porting to llvm-18 #537
Porting to llvm-18 #537
Conversation
Clang format seems to have caused some files to be formatted differently, which makes the diff larger than necessary.
|
@sjalander Could you put the change in the CI where you introduce the |
There was a problem hiding this comment.
@haved @caleridas Any objections for moving over to LLVM 18?
|
@haved @caleridas Any objections to moving to LLVM 18? |
Nope, I'm all for it. |
|
@sjalander Could finish up this PR such that we can merge it, please? |
|
@phate |
There was a problem hiding this comment.
@sjalander The comments that are still open (or were closed without actually fixing the issue).
|
@phate There might be something weird going on with GitHub and responses to comments, because I am fairly certain I saw on @sjalander's screen that he had written several responses to comments that I am not seeing on my own devices. For example regarding the |
|
@phate |
|
@phate GitHub is behaving quite strangely. I can see all of @sjalander's comments now, but they are all independent of the comments they reply to. They also show an older version of the changes made in this PR, without having the "outdated" tag that I usually expect when a comment is made on an outdated diff |
Clang format seems to have caused some files to be formatted differently, which makes the diff larger than necessary.