Bump actions/checkout from 3 to 4 #72

dependabot · 2023-09-09T10:09:29Z

Release notes

Sourced from actions/checkout's releases.

v4.0.0

What's Changed

Update default runtime to node20 by @takost in actions/checkout#1436

Support fetching without the --progress option by @simonbaird in actions/checkout#1067

Release 4.0.0 by @takost in actions/checkout#1447

New Contributors

@takost made their first contribution in actions/checkout#1436

@simonbaird made their first contribution in actions/checkout#1067

Full Changelog: actions/checkout@v3...v4.0.0

v3.6.0

What's Changed

Mark test scripts with Bash'isms to be run via Bash by @dscho in actions/checkout#1377

Add option to fetch tags even if fetch-depth > 0 by @RobertWieczoreck in actions/checkout#579

Release 3.6.0 by @luketomlinson in actions/checkout#1437

New Contributors

@RobertWieczoreck made their first contribution in actions/checkout#579

@luketomlinson made their first contribution in actions/checkout#1437

Full Changelog: actions/checkout@v3.5.3...v3.6.0

v3.5.3

What's Changed

Fix: Checkout Issue in self hosted runner due to faulty submodule check-ins by @megamanics in actions/checkout#1196

Fix typos found by codespell by @DimitriPapadopoulos in actions/checkout#1287

Add support for sparse checkouts by @dscho and @dfdez in actions/checkout#1369

Release v3.5.3 by @TingluoHuang in actions/checkout#1376

New Contributors

@megamanics made their first contribution in actions/checkout#1196

@DimitriPapadopoulos made their first contribution in actions/checkout#1287

@dfdez made their first contribution in actions/checkout#1369

Full Changelog: actions/checkout@v3...v3.5.3

v3.5.2

What's Changed

Fix: Use correct API url / endpoint in GHES by @fhammerl in actions/checkout#1289 based on #1286 by @1newsr

Full Changelog: actions/checkout@v3.5.1...v3.5.2

v3.5.1

What's Changed

Improve checkout performance on Windows runners by upgrading @actions/github dependency by @BrettDong in actions/checkout#1246

New Contributors

@BrettDong made their first contribution in actions/checkout#1246

... (truncated)

Changelog

Sourced from actions/checkout's changelog.

Changelog

v4.0.0

Support fetching without the --progress option

Update to node20

v3.6.0

Fix: Mark test scripts with Bash'isms to be run via Bash

Add option to fetch tags even if fetch-depth > 0

v3.5.3

Fix: Checkout fail in self-hosted runners when faulty submodule are checked-in

Fix typos found by codespell

Add support for sparse checkouts

v3.5.2

Fix api endpoint for GHES

v3.5.1

Fix slow checkout on Windows

v3.5.0

Add new public key for known_hosts

v3.4.0

Upgrade codeql actions to v2

Upgrade dependencies

Upgrade @actions/io

v3.3.0

Implement branch list using callbacks from exec function

Add in explicit reference to private checkout options

[Fix comment typos (that got added in #770)](actions/checkout#1057)

v3.2.0

Add GitHub Action to perform release

Fix status badge

Replace datadog/squid with ubuntu/squid Docker image

Wrap pipeline commands for submoduleForeach in quotes

Update @actions/io to 1.1.2

Upgrading version to 3.2.0

v3.1.0

Use @actions/core saveState and getState

Add github-server-url input

v3.0.2

Add input set-safe-directory

v3.0.1

... (truncated)

Commits

3df4ab1 Release 4.0.0 (#1447)
8b5e8b7 Support fetching without the --progress option (#1067)
97a652b Update default runtime to node20 (#1436)
See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

yubiuser · 2023-09-09T15:17:53Z

All FTL builds fail, but likely unrelated to this PR

DL6ER · 2023-09-09T15:55:13Z

It is because #69 is still not merged despite being used by FTL for months. Reading this PR again, I think the missing ingredient is the formal request for a review which I just added :-)

PromoFaux · 2023-09-10T15:23:16Z

@dependabot rebase

dependabot · 2023-09-10T15:23:18Z

Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

PromoFaux · 2023-09-10T15:23:37Z

@dependabot recreate

yubiuser · 2023-09-10T19:12:52Z

Now it fails because it can't login to docker.io.

But it should have access to the credentials via the inputs. However, it only got

Run ./.github/actions/login-repo
  with:
    ghcr_username: pi-hole
    ghcr_password: ***

yubiuser · 2023-09-10T19:17:39Z

Can someone please check, if those secrets exist

docker-base-images/.github/workflows/ftl-build.yml

Lines 165 to 169 in 3a63fd4

    
           with: 
        
             docker_username: ${{ secrets.DOCKERHUB_USER }} 
        
             docker_password: ${{ secrets.DOCKERHUB_PASS }} 
        
             ghcr_username: ${{ github.repository_owner }} 
        
             ghcr_password: ${{ secrets.GITHUB_TOKEN }}

PromoFaux · 2023-09-11T13:20:59Z

They are there and available to actions... weird.

yubiuser · 2023-09-12T08:57:18Z

@dependabot recreate

yubiuser · 2023-09-12T11:35:21Z

I pushed a commit that will check the inputs for emptyness. Despite being marked as required, GHA does not check them....

https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#example-specifying-inputs

Note: workflows using required: true will not automatically return an error if the input is not specified for events that automatically trigger workflow runs.

and
actions/runner#1070

yubiuser · 2023-09-12T11:45:32Z

I also added a trigger for the ftl builds to run on changes to the action files.

yubiuser · 2023-09-12T11:49:57Z

Seems to work now - not really sure why.

yubiuser · 2023-09-16T13:23:15Z

Would like to get another pair of eyes here - with this PR, all the other dependabot PRs will continue to fail.

PromoFaux · 2023-09-20T23:14:43Z

Seems to work now - not really sure why.

PromoFaux · 2023-09-20T23:24:25Z

Should be fixed by #77

PromoFaux · 2023-09-21T14:48:56Z

@dependabot recreate

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>

yubiuser · 2023-09-27T19:27:00Z

Mhh... dependabot pushed away my checks

I pushed a commit that will check the inputs for emptyness.

and the trigger for changes to the action

I also added a trigger for the ftl builds to run on changes to the action files.

dependabot bot added the dependencies Pull requests that update a dependency file label Sep 9, 2023

dependabot bot requested a review from a team September 9, 2023 10:09

yubiuser approved these changes Sep 9, 2023

View reviewed changes

dependabot bot force-pushed the dependabot/github_actions/master/actions/checkout-4 branch from 1772647 to 16d9dd5 Compare September 10, 2023 11:48

dependabot bot force-pushed the dependabot/github_actions/master/actions/checkout-4 branch from 16d9dd5 to 0f77a84 Compare September 10, 2023 15:23

dependabot bot force-pushed the dependabot/github_actions/master/actions/checkout-4 branch from 0f77a84 to 1c2ee98 Compare September 12, 2023 08:57

yubiuser approved these changes Sep 12, 2023

View reviewed changes

yubiuser requested review from PromoFaux and DL6ER September 12, 2023 11:50

dependabot bot force-pushed the dependabot/github_actions/master/actions/checkout-4 branch from 9bc7948 to 7e0c5b8 Compare September 21, 2023 14:49

PromoFaux merged commit ac5de77 into master Sep 21, 2023
11 checks passed

dependabot bot deleted the dependabot/github_actions/master/actions/checkout-4 branch September 21, 2023 16:05

yubiuser mentioned this pull request Sep 27, 2023

Tweak/ftl build #79

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump actions/checkout from 3 to 4 #72

Bump actions/checkout from 3 to 4 #72

dependabot bot commented on behalf of github Sep 9, 2023 •

edited

Loading

yubiuser commented Sep 9, 2023

DL6ER commented Sep 9, 2023

PromoFaux commented Sep 10, 2023

dependabot bot commented on behalf of github Sep 10, 2023

PromoFaux commented Sep 10, 2023

yubiuser commented Sep 10, 2023

yubiuser commented Sep 10, 2023 •

edited

Loading

PromoFaux commented Sep 11, 2023

yubiuser commented Sep 12, 2023

yubiuser commented Sep 12, 2023 •

edited

Loading

yubiuser commented Sep 12, 2023

yubiuser commented Sep 12, 2023

yubiuser commented Sep 16, 2023

PromoFaux commented Sep 20, 2023

PromoFaux commented Sep 20, 2023

PromoFaux commented Sep 21, 2023

yubiuser commented Sep 27, 2023

Bump actions/checkout from 3 to 4 #72

Bump actions/checkout from 3 to 4 #72

Conversation

dependabot bot commented on behalf of github Sep 9, 2023 • edited Loading

v4.0.0

What's Changed

New Contributors

v3.6.0

What's Changed

New Contributors

v3.5.3

What's Changed

New Contributors

v3.5.2

What's Changed

v3.5.1

What's Changed

New Contributors

Changelog

v4.0.0

v3.6.0

v3.5.3

v3.5.2

v3.5.1

v3.5.0

v3.4.0

v3.3.0

v3.2.0

v3.1.0

v3.0.2

v3.0.1

yubiuser commented Sep 9, 2023

DL6ER commented Sep 9, 2023

PromoFaux commented Sep 10, 2023

dependabot bot commented on behalf of github Sep 10, 2023

PromoFaux commented Sep 10, 2023

yubiuser commented Sep 10, 2023

yubiuser commented Sep 10, 2023 • edited Loading

PromoFaux commented Sep 11, 2023

yubiuser commented Sep 12, 2023

yubiuser commented Sep 12, 2023 • edited Loading

yubiuser commented Sep 12, 2023

yubiuser commented Sep 12, 2023

yubiuser commented Sep 16, 2023

PromoFaux commented Sep 20, 2023

PromoFaux commented Sep 20, 2023

PromoFaux commented Sep 21, 2023

yubiuser commented Sep 27, 2023

dependabot bot commented on behalf of github Sep 9, 2023 •

edited

Loading

yubiuser commented Sep 10, 2023 •

edited

Loading

yubiuser commented Sep 12, 2023 •

edited

Loading