-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make urls use bps sans ttfb #407
Conversation
🚫 CI failed with log |
🚫 CI failed with log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine, some naming and documentation things.
Source/Classes/PINProgressiveImage.h
Outdated
Returns bytes per second adjusted by subtracting subtraction from the task length before calculation. | ||
Useful when you want something like bytesPerSecond discounting the time to first byte. | ||
|
||
@param subtraction an amount to be subtracted from task length befor calculation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capital An
, before calculation
.
@@ -128,6 +128,31 @@ - (float)l_bytesPerSecond | |||
return downloadedBytes / taskLength; | |||
} | |||
|
|||
- (float)adjustedBytesPerSecond:(CFTimeInterval)subtraction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bytesPerSecondWithTimeToFirstByte:
?
🚫 CI failed with log |
No description provided.