Fix "unset" value for property ktlint_chain_method_rule_force_multili…

…ne_when_chain_operator_count_greater_or_equal_than when it has (#2728) When value is set to "unset" the number of chain operators on a single line is not restricted as long as the max line length is not exceeded. Closes #2712
pinterest · Jul 2, 2024 · 91d8d44 · 91d8d44
1 parent 15fb36d
commit 91d8d44
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/...rc/main/kotlin/com/pinterest/ktlint/ruleset/standard/rules/ChainMethodContinuationRule.kt b/...rc/main/kotlin/com/pinterest/ktlint/ruleset/standard/rules/ChainMethodContinuationRule.kt
@@ -489,7 +489,7 @@ public class ChainMethodContinuationRule :
         private val chainOperatorTokenSet = TokenSet.create(DOT, SAFE_ACCESS)
         private val groupClosingElementType = TokenSet.create(CLOSING_QUOTE, RBRACE, RBRACKET, RPAR)
 
-        private const val FORCE_MULTILINE_WHEN_CHAIN_OPERATOR_COUNT_GREATER_OR_EQUAL_THAN_PROPERTY_UNSET = 4
+        private const val FORCE_MULTILINE_WHEN_CHAIN_OPERATOR_COUNT_GREATER_OR_EQUAL_THAN_PROPERTY_UNSET = Int.MAX_VALUE
         public val FORCE_MULTILINE_WHEN_CHAIN_OPERATOR_COUNT_GREATER_OR_EQUAL_THAN_PROPERTY: EditorConfigProperty<Int> =
             EditorConfigProperty(
                 type =
@@ -500,7 +500,7 @@ public class ChainMethodContinuationRule :
                         PropertyType.PropertyValueParser.POSITIVE_INT_VALUE_PARSER,
                         setOf("1", "2", "3", "4", "5", "6", "7", "8", "9", "unset"),
                     ),
-                defaultValue = FORCE_MULTILINE_WHEN_CHAIN_OPERATOR_COUNT_GREATER_OR_EQUAL_THAN_PROPERTY_UNSET,
+                defaultValue = 4,
                 propertyMapper = { property, _ ->
                     if (property?.isUnset == true) {
                         FORCE_MULTILINE_WHEN_CHAIN_OPERATOR_COUNT_GREATER_OR_EQUAL_THAN_PROPERTY_UNSET

diff --git a/...est/kotlin/com/pinterest/ktlint/ruleset/standard/rules/ChainMethodContinuationRuleTest.kt b/...est/kotlin/com/pinterest/ktlint/ruleset/standard/rules/ChainMethodContinuationRuleTest.kt
@@ -1117,4 +1117,16 @@ class ChainMethodContinuationRuleTest {
                 LintViolation(4, 59, "Expected newline before '.'"),
             ).isFormattedAs(formattedCode)
     }
+
+    @Test
+    fun `Issue 2712 - Given some code having more chain operators than the default, but with ktlint_chain_method_rule_force_multiline_when_chain_operator_count_greater_or_equal_than unset`() {
+        val code =
+            """
+            val foo = listOf(1, 2, 3).plus(4).plus(5).plus(6).plus(7).plus(8)
+            """.trimIndent()
+        require(code.count { it == '.' } > FORCE_MULTILINE_WHEN_CHAIN_OPERATOR_COUNT_GREATER_OR_EQUAL_THAN_PROPERTY.defaultValue)
+        chainMethodContinuationRuleAssertThat(code)
+            .withEditorConfigOverride(FORCE_MULTILINE_WHEN_CHAIN_OPERATOR_COUNT_GREATER_OR_EQUAL_THAN_PROPERTY to "unset")
+            .hasNoLintViolations()
+    }
 }