Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve insert of suppression #2546

Merged
merged 3 commits into from
Feb 11, 2024
Merged

Conversation

paul-dingemans
Copy link
Collaborator

Description

Improve insert of suppression:

  • Prevent KtlintSuppressionOutOfBoundsException Suppression if offset equals the end the line.
  • Insert suppression at parent in case the target location of the suppression is a whitespace.

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

Prevent KtlintSuppressionOutOfBoundsException Suppression if offset equals the end the line.

Insert suppression at parent in case the target location of the suppression is a whitespace.
Prevent KtlintSuppressionOutOfBoundsException Suppression if offset equals the end the line.

Closes #2514

Insert suppression at parent in case the target location of the suppression is a whitespace.
Prevent KtlintSuppressionOutOfBoundsException Suppression if offset equals the end the line.

Closes #2514

Insert suppression at parent in case the target location of the suppression is a whitespace.
@paul-dingemans paul-dingemans added this to the 1.2 milestone Feb 11, 2024
@paul-dingemans paul-dingemans merged commit 1b7c449 into master Feb 11, 2024
12 checks passed
@paul-dingemans paul-dingemans deleted the 2514-ktlint-rule-suppression branch February 11, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant