Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify default properties loading #2679

Merged

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented May 31, 2024

Description

The file path will be checked in com.pinterest.ktlint.rule.engine.internal.EditorConfigDefaultsLoader.load, no need to check nullability again.

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

The file path will be checked in `com.pinterest.ktlint.rule.engine.internal.EditorConfigDefaultsLoader.load`, no need to check nullability again.
@paul-dingemans paul-dingemans merged commit fc164be into pinterest:master Jun 1, 2024
11 checks passed
@Goooler Goooler deleted the simplify-empty-config-loading branch June 1, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants