Reducers: add default handler #241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, do you have any news on this? I need this desperately. @piotrwitek could you please merge this? |
|
lol - i need this too! |
piotrwitek
reviewed
Jan 12, 2022
| @@ -7,10 +7,12 @@ import { getType } from './get-type'; | |||
| const add = createAction('ADD')<number>(); | |||
| const increment = createAction('INCREMENT')(); | |||
| const decrement = createAction('DECREMENT')(); | |||
| const reduxInit = createAction('@@redux/INIT.1')(); | |||
There was a problem hiding this comment.
reduxInit cannot be handled as it is implementation details of Redux not a public API, so please remove completely
piotrwitek
requested changes
Jan 12, 2022
| ```ts | ||
| const counterReducer = createReducer(0) | ||
| .handleAction(add, (state, action) => state + action.payload) | ||
| .defaultHandler((state, action) => state = 0, true); |
There was a problem hiding this comment.
because reduxInit cannot be handled as it is implementation details of Redux and not a public API, second parameter is not necessary, it should be always invoked by initialization and should be handled in the user code as needed
9 tasks
|
@piotrwitek |
|
closed because it's stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a defaultHandler for reducers
Related issues:
Checklist
For bugfixes:
For new features:
dts-jestdts-jestIssueHunt Summary
Referenced issues
This pull request has been submitted to: