Fix opgg provider #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chobocharles
reviewed
Mar 1, 2021
|
Yeah it's just preference, I usually write all my code using |
|
Ah, okie dokes, thank you :) |
|
Yeah. like @pipe01 said, it's just a coding style that i'm using (for work and hobby projects). I'm explicitly defining types when boxing could fail or compiler could not automatically resolve a type. Also i believe that this PR is outdated as hell, cause markdown could be changed many times for past 2 years. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetching of item builds from op.gg.
Haven't tested it in-game, but should work properly.