Skip to content
This repository has been archived by the owner on Jan 18, 2018. It is now read-only.

Remove: account.leagueoflegends.com #199

Merged
merged 1 commit into from
Feb 26, 2017
Merged

Conversation

markofu
Copy link
Contributor

@markofu markofu commented Feb 26, 2017

Remove: account.leagueoflegends.com -> confirmation sent via email.

Remove: account.leagueoflegends.com -> confirmation sent via email.
@Phineas
Copy link
Contributor

Phineas commented Feb 26, 2017

@markofu This domain was & still is using the proxy service.

@Phineas Phineas closed this Feb 26, 2017
@Phineas Phineas reopened this Feb 26, 2017
@Phineas
Copy link
Contributor

Phineas commented Feb 26, 2017

Never mind, received the email - removing the domain. Thank you!

@markofu
Copy link
Contributor Author

markofu commented Feb 26, 2017

Thanks @Phineas 👍

Copy link
Contributor

@Phineas Phineas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proof

@Phineas Phineas merged commit 411067f into pirate:master Feb 26, 2017
@tonyztan
Copy link
Contributor

tonyztan commented Feb 26, 2017

@Phineas @pirate Have we changed the policy? Why is a website currently using the proxy being removed? Thanks.

@Phineas
Copy link
Contributor

Phineas commented Feb 26, 2017

@tonyztan They got an email specifically from Cloudflare saying their domain wasn't affected, I was forwarded it.

@tonyztan
Copy link
Contributor

@Phineas Would this be a similar situation to #154 and #153, where there is "no evidence of compromised data", meaning "no leaked data found in several search engine caches", but also no positive evidence that definitely no data was leaked from the site at any point?

@Phineas
Copy link
Contributor

Phineas commented Feb 26, 2017

@tonyztan Cloudflare specifically said in the email that their site was not affected in any way and their site was not on an affected proxy

@tonyztan
Copy link
Contributor

@Phineas I see. Thanks!

@tonyztan
Copy link
Contributor

@coderobe
Copy link
Contributor

I don't know why this PR was merged. It should not have been IMO.

@abalabahaha
Copy link
Contributor

The way Phineas worded his comment sounded like Cloudflare had responded personally to a support email, but the email subject in the screenshot he posted looks like the misleading blanket email Cloudflare sent...

@coderobe
Copy link
Contributor

That's what it sounds like, yeah. CC @Phineas

@pirate
Copy link
Owner

pirate commented Feb 28, 2017

@Phineas or @markofu can one of you forward me the Cloudflare email to [email protected]? If it was the blanket "your data wasn't found in caches" email, then I'd like to revert this PR asap, there's a lot of questioning going around the League of Legends forums and it would be nice to clear it up. It would also be great to link to an official LoL Cloudbleed response blog post, although afaik they haven't published one yet.

@markofu
Copy link
Contributor Author

markofu commented Mar 1, 2017

@pirate Hey, which questions are you referring to?

I work in Security at Riot (google me, if you want proof more proof, let me know). Regarding official word, we officially posted on LoL Subreddit last Friday evening. We may still post to the Forums but I'm doubtful on that. We have answered players' questions and concerns via the Subreddit and through our Player Support system.

We have had several calls with Cloudflare and I've forwarded you on a private email to us (at Riot).

If you still want to revert the PR, that's your call and I defer to your judgement on it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants