Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct CoW command for macOS #222

Merged
merged 1 commit into from
Aug 10, 2023
Merged

correct CoW command for macOS #222

merged 1 commit into from
Aug 10, 2023

Conversation

kapitainsky
Copy link
Contributor

There is no cp --reflink on macOS

It is cp -c instead

fixes: #219

boozook
boozook approved these changes Aug 9, 2023
View reviewed changes
Copy link

@boozook boozook left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! ❤️‍🔥

Could be great to mention somewhere that requirements for this is now

  • macOS: 10.12 "Sierra" (when appears cp -c)
  • FS: APFS (cp -c should work on others, but probably don't do CoW in non-APFS fs)

@pkolaczk pkolaczk merged commit bbc2592 into pkolaczk:main Aug 10, 2023
5 checks passed
@kapitainsky kapitainsky deleted the macOS_CoW branch August 10, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boozook boozook boozook approved these changes

@pkolaczk pkolaczk pkolaczk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[dedup] Use APFS clone (CoW) on macOS
3 participants
@kapitainsky @boozook @pkolaczk