Search prod ready #114
Search prod ready #114
Conversation
Search tool
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hyusap
requested review from
VVoruganti and
vintrocode
and removed request for
VVoruganti
| @@ -63,13 +84,31 @@ def think(cls, cache: Conversation, input: str): | |||
|
|
|||
| @classmethod | |||
| @sentry_sdk.trace | |||
| def respond(cls, cache: Conversation, thought: str, input: str): | |||
| async def respond(cls, cache: Conversation, thought: str, input: str): | |||
There was a problem hiding this comment.
The inferences for the search tool are all done sequentially so there isn't any added benefit of running it with async and it changes up the interface elsewhere the respond method is used.
For consistency we should remove those. I'm also wondering if the logic for tools should be encoded within the respond method or the BloomChain class should have a set of methods for tool support then we just add that to the chat and stream methods
There was a problem hiding this comment.
Hm, I did include a synchronous implementation for the search tool, but right now it's set up to use the async implementation which does each inference async and is much faster from my testing.
I agree on the interface issue, do you think using threads instead here might be cleaner?
There was a problem hiding this comment.
I think for now, nest_asyncio should work to make the search_tool call sync. It seems like Langchain doesn't really work with threading yet.
There was a problem hiding this comment.
I've also decoupled the search logic from respond, so feel free to let me know your thoughts on that too!
* implement autoscroll Refactored imports in "page.tsx" to improve readability and maintainability. Updated the type of the "input" ref to be more specific. Added a new state and ref to track the scroll position of the message container. Set up an event listener to update the state when the scroll position changes. Made adjustments to the scroll position in certain event handlers. * update scroll --------- Co-authored-by: Vineeth Voruganti <[email protected]>
- Update langchain to fix thoughts not appearing issue - Switch to regular HTML Loader instead of playwright for simplicity and performance - Update search prompt to fix citation formatting issues - Downgrade remark to prevent Math rendering error (source: remarkjs/remark-math#89)
|
Issue is stale and out of date. Closing for now |
No description provided.