Support for LongArrayTag #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dktapps
added a commit
that referenced
this pull request
Feb 14, 2018
This should catch bugs when new tags are added (like #36).
dktapps
force-pushed
the
long-array
branch
2 times, most recently
from
e88526a
to
9d1be24
Compare
dktapps
force-pushed
the
master
branch
2 times, most recently
from
f7dcf34
to
8be1d97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently untested.
Additionally MCPE doesn't have TAG_LongArray yet, so it is possible they may botch up its addition and screw up the consistency. The
LittleEndianNBTStreamandNetworkLittleEndianNBTStreamare the expected logic paths should the format remain consistent with PC.Closes #35 .