Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make version optional #85

Closed
nicodes opened this issue Jun 7, 2023 · 2 comments · Fixed by #90
Closed

Make version optional #85

nicodes opened this issue Jun 7, 2023 · 2 comments · Fixed by #90

Comments

@nicodes
Copy link

nicodes commented Jun 7, 2023

I think the mandatory version should be made optional and default to the latest stable. This will lower the entry barrier for first time users, and can cause confusion with the action version vs pnpm version.

Current:

- uses: pnpm/action-setup@v2
        with:
          version: 7

Proposed:

- uses: pnpm/action-setup@v2
@KSXGitHub

This comment was marked as outdated.

@KSXGitHub
Copy link
Collaborator

KSXGitHub commented Jul 25, 2023

If version is not specified, packageManager field in package.json would be required. If both don't exist, there would be error.

The reason it was made an error was because we'd like to have the freedom of making breaking changes without fear of breaking existing CIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants