Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re: Add conan support #753

Merged
merged 12 commits into from
Apr 5, 2023
Merged

Re: Add conan support #753

merged 12 commits into from
Apr 5, 2023

Conversation

wx257osn2
Copy link
Contributor

@wx257osn2 wx257osn2 commented Apr 3, 2023

related: #684

This PR contains below:

  • Add "package" = {version = "...", registry = "conan-v1"} syntax
    • "package" = {version = "..."} and "package" = {version = "...", registry = "poac"} is same as "package" = "..."
  • Add conan v1 support
    • About 10 days ago, conan v2 had been released. This PR doesn't support that.

See https://github.com/wx257osn2/poac-conan-demo for usage.

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b47c245) 98.09% compared to head (b8deb54) 98.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #753   +/-   ##
=======================================
  Coverage   98.09%   98.09%           
=======================================
  Files          52       52           
  Lines        2526     2526           
=======================================
  Hits         2478     2478           
  Misses         48       48           
Impacted Files Coverage Δ
include/poac/core/resolver/resolve.hpp 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ken-matsui
Copy link
Member

@wx257osn2 Fixed the build errors caused on macOS. Please let me know when this PR gets ready.

@wx257osn2
Copy link
Contributor Author

@ken-matsui IMO we should support conan v2, but it may be not necessarily to contains that in this PR.
How do you think? If you will decide to separate PR to support v2, this PR will be ready to review.
If not, I will research how to use v2, and implement it. It will take some time to do, but...

@ken-matsui
Copy link
Member

@wx257osn2 You do not have to care about V2 for now. This PR should focus on V1. Thanks!

@wx257osn2 wx257osn2 marked this pull request as ready for review April 5, 2023 07:31
Copy link
Member

@ken-matsui ken-matsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your time to work on this PR!

@ken-matsui ken-matsui merged commit 3052403 into main Apr 5, 2023
@ken-matsui ken-matsui deleted the add-conan-support branch April 5, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants