Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Products List API: include_archived is a bad filter #3597

Closed
frankie567 opened this issue Jul 4, 2024 · 0 comments · Fixed by #3631
Closed

Products List API: include_archived is a bad filter #3597

frankie567 opened this issue Jul 4, 2024 · 0 comments · Fixed by #3631
Assignees
@frankie567
Labels
api

Comments

@frankie567
Copy link
Member

include_archived is a required query parameter boolean, with default to False.

We should change this parameter like we do for other filters of the API to an optional is_archived parameter with a default to None (meaning: no filter on this parameter, everything is returned by default).

⚠️ In the Web UI, we should go over the requests to this endpoint to add this parameter where needed (almost everywhere I believe).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frankie567 frankie567

Labels
api
Projects
Polar
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Products API: replace include_archived by is_archived polarsource/polar
1 participant
@frankie567