Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Products API: replace include_archived by is_archived #3631

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Conversation

frankie567
Copy link
Member

Fix #3597

@frankie567 frankie567 enabled auto-merge (rebase) July 9, 2024 15:09
Copy link

vercel bot commented Jul 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
polar 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 3:09pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
polar-next-js-example ⬜️ Ignored (Inspect) Jul 9, 2024 3:09pm

Copy link
Contributor

github-actions bot commented Jul 9, 2024

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 226.42 KB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Ninety-four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/layout 56.49 KB 282.91 KB 80.83% (+/- <0.01%)
/maintainer/page 449.49 KB 675.91 KB 193.12% (+/- <0.01%)
/login/page 67.71 KB 294.13 KB 84.04% (+/- <0.01%)
/signup/maintainer/page 37.31 KB 263.73 KB 75.35% (+/- <0.01%)
/(installation)/github/installation/page 63.78 KB 290.2 KB 82.91% (+/- <0.01%)
/(topbar)/checkout/success/page 94.57 KB 320.99 KB 91.71% (+/- <0.01%)
/(topbar)/layout 183.44 KB 409.86 KB 117.10% (+/- <0.01%)
/(topbar)/unsubscribe/page 31.41 KB 257.83 KB 73.67% (+/- <0.01%)
/[organization]/(sidebar)/donate/page 198.04 KB 424.46 KB 121.27% (🟡 +0.01%)
/[organization]/(sidebar)/layout 192.65 KB 419.07 KB 119.73% (🟡 +0.01%)
/[organization]/(sidebar)/issues/page 127.41 KB 353.83 KB 101.09% (🟡 +0.01%)
/[organization]/(sidebar)/donate/status/page 39.92 KB 266.34 KB 76.10% (+/- <0.01%)
/[organization]/(sidebar)/page 231.22 KB 457.64 KB 130.75% (🟡 +0.01%)
/[organization]/(sidebar)/posts/[postSlug]/page 197.65 KB 424.07 KB 121.16% (+/- <0.01%)
/[organization]/(sidebar)/posts/page 138.99 KB 365.41 KB 104.40% (+/- <0.01%)
/[organization]/(sidebar)/products/[productId]/page 135.89 KB 362.31 KB 103.52% (+/- <0.01%)
/[organization]/(sidebar)/products/page 103.41 KB 329.83 KB 94.24% (+/- <0.01%)
/[organization]/(sidebar)/subscriptions/page 157.6 KB 384.02 KB 109.72% (+/- <0.01%)
/[organization]/(sidebar)/repositories/page 67.47 KB 293.89 KB 83.97% (+/- <0.01%)
/[organization]/[repo]/issues/[number]/(create)/page 154.79 KB 381.21 KB 108.92% (+/- <0.01%)
/[organization]/[repo]/layout 132.25 KB 358.67 KB 102.48% (+/- <0.01%)
/[organization]/[repo]/issues/[number]/status/page 181.29 KB 407.71 KB 116.49% (+/- <0.01%)
/[organization]/[repo]/page 222.6 KB 449.02 KB 128.29% (+/- <0.01%)
/[organization]/subscribe/page 144.64 KB 371.06 KB 106.02% (+/- <0.01%)
/backoffice/issue/[id]/page 62.64 KB 289.06 KB 82.59% (+/- <0.01%)
/backoffice/layout 456.68 KB 683.1 KB 195.17% (+/- <0.01%)
/backoffice/badge/page 53.05 KB 279.47 KB 79.85% (+/- <0.01%)
/backoffice/pledges/page 64.76 KB 291.18 KB 83.20% (+/- <0.01%)
/backoffice/rewards_pending/page 66.26 KB 292.68 KB 83.62% (+/- <0.01%)
/backoffice/rebadge/page 39.78 KB 266.2 KB 76.06% (🟢 -0.01%)
/maintainer/(onboarding)/[organization]/onboarding/page 123.18 KB 349.6 KB 99.89% (+/- <0.01%)
/docs/api/[...endpoint]/page 420.82 KB 647.24 KB 184.93% (+/- <0.01%)
/docs/layout 130.66 KB 357.08 KB 102.02% (🟡 +0.01%)
/(landing)/(features)/issue-funding/page 138.83 KB 365.25 KB 104.36% (+/- <0.01%)
/(landing)/(features)/newsletters/page 154.43 KB 380.85 KB 108.81% (🟡 +0.01%)
/(landing)/(features)/products/page 153.87 KB 380.29 KB 108.65% (🟡 +0.01%)
/(landing)/page 138.7 KB 365.12 KB 104.32% (+/- <0.01%)
/(landing)/(features)/benefits/page 138.83 KB 365.25 KB 104.36% (+/- <0.01%)
/(landing)/(features)/donations/page 138.83 KB 365.25 KB 104.36% (+/- <0.01%)
/(topbar)/(backer)/layout 53.7 KB 280.13 KB 80.04% (+/- <0.01%)
/(topbar)/(backer)/purchases/products/[id]/page 209.79 KB 436.21 KB 124.63% (+/- <0.01%)
/(topbar)/(backer)/purchases/products/page 103.31 KB 329.74 KB 94.21% (+/- <0.01%)
/(topbar)/(backer)/purchases/subscriptions/[id]/page 211.7 KB 438.12 KB 125.18% (+/- <0.01%)
/(topbar)/(backer)/purchases/subscriptions/page 96.7 KB 323.12 KB 92.32% (+/- <0.01%)
/(topbar)/(backer)/settings/page 216.01 KB 442.43 KB 126.41% (+/- <0.01%)
/maintainer/[organization]/(topbar)/layout 456.68 KB 683.1 KB 195.17% (+/- <0.01%)
/maintainer/[organization]/(topbar)/donations/overview/page 573.88 KB 800.31 KB 228.66% (+/- <0.01%)
/maintainer/[organization]/(topbar)/funding/page 477.79 KB 704.22 KB 201.20% (+/- <0.01%)
/maintainer/[organization]/(topbar)/issues/badge/page 468.87 KB 695.29 KB 198.65% (+/- <0.01%)
/maintainer/[organization]/(topbar)/initialize/page 150.67 KB 377.09 KB 107.74% (+/- <0.01%)
/maintainer/[organization]/(topbar)/issues/overview/page 485.05 KB 711.47 KB 203.28% (+/- <0.01%)
/maintainer/[organization]/(topbar)/members/page 446.82 KB 673.24 KB 192.35% (+/- <0.01%)
/maintainer/[organization]/(topbar)/overview/page 473.41 KB 699.83 KB 199.95% (+/- <0.01%)
/maintainer/[organization]/(topbar)/posts/analytics/page 566.99 KB 793.41 KB 226.69% (+/- <0.01%)
/maintainer/[organization]/(topbar)/posts/page 557.54 KB 783.96 KB 223.99% (+/- <0.01%)
/maintainer/[organization]/(topbar)/products/benefits/page 538.76 KB 765.18 KB 218.62% (+/- <0.01%)
/maintainer/[organization]/(topbar)/sales/orders/page 479.22 KB 705.64 KB 201.61% (+/- <0.01%)
/maintainer/[organization]/(topbar)/sales/overview/page 570.48 KB 796.9 KB 227.68% (+/- <0.01%)
/maintainer/[organization]/(topbar)/products/overview/page 476.25 KB 702.67 KB 200.76% (+/- <0.01%)
/maintainer/[organization]/(topbar)/sales/subscriptions/page 492.09 KB 718.51 KB 205.29% (+/- <0.01%)
/maintainer/[organization]/(topbar)/settings/webhooks/endpoints/[id]/page 488.74 KB 715.16 KB 204.33% (+/- <0.01%)
/maintainer/[organization]/(topbar)/settings/page 462.35 KB 688.77 KB 196.79% (+/- <0.01%)
/maintainer/[organization]/(white)/posts/[post]/page 554.5 KB 780.92 KB 223.12% (+/- <0.01%)
/maintainer/[organization]/(white)/layout 441.34 KB 667.76 KB 190.79% (+/- <0.01%)
/maintainer/[organization]/(white)/posts/new/page 552.14 KB 778.56 KB 222.45% (🟢 -0.01%)
/maintainer/[organization]/products/[id]/page 528.17 KB 754.59 KB 215.60% (+/- <0.01%)
/maintainer/[organization]/products/layout 441.34 KB 667.76 KB 190.79% (+/- <0.01%)
/maintainer/[organization]/products/new/page 527.85 KB 754.27 KB 215.51% (+/- <0.01%)
/maintainer/[organization]/promote/page 463.33 KB 689.75 KB 197.07% (+/- <0.01%)
/maintainer/[organization]/promote/layout 441.34 KB 667.76 KB 190.79% (+/- <0.01%)
/docs/(mdx)/layout 393.08 KB 619.5 KB 177.00% (+/- <0.01%)
/docs/(mdx)/faq/for-contributors/page 30.51 KB 256.93 KB 73.41% (+/- <0.01%)
/docs/(mdx)/guides/page 30.51 KB 256.93 KB 73.41% (+/- <0.01%)
/docs/api/(mdx)/layout 393.06 KB 619.49 KB 177.00% (🟢 -0.01%)
/docs/contribute/layout 393.08 KB 619.5 KB 177.00% (+/- <0.01%)
/docs/support/layout 393.08 KB 619.5 KB 177.00% (+/- <0.01%)
/(topbar)/(backer)/(sidebar)/feed/page 136.19 KB 362.62 KB 103.60% (🟡 +0.01%)
/(topbar)/(backer)/(sidebar)/layout 91.29 KB 317.71 KB 90.77% (🟡 +0.01%)
/(topbar)/(backer)/finance/account/page 172.09 KB 398.51 KB 113.86% (+/- <0.01%)
/(topbar)/(backer)/finance/layout 154.26 KB 380.68 KB 108.77% (+/- <0.01%)
/(topbar)/(backer)/(sidebar)/funding/page 201.22 KB 427.64 KB 122.18% (🟡 +0.01%)
/(topbar)/(backer)/finance/incoming/page 186.96 KB 413.38 KB 118.11% (+/- <0.01%)
/(topbar)/(backer)/finance/issue-funding/page 71.6 KB 298.02 KB 85.15% (+/- <0.01%)
/(topbar)/(backer)/finance/issue-funding/contributors/page 71.01 KB 297.43 KB 84.98% (+/- <0.01%)
/(topbar)/(backer)/finance/outgoing/page 139.08 KB 365.5 KB 104.43% (+/- <0.01%)
/(topbar)/(backer)/finance/rewards/page 71.09 KB 297.52 KB 85.00% (🟡 +0.01%)
/maintainer/[organization]/(topbar)/finance/account/page 173.19 KB 399.61 KB 114.17% (🟡 +0.01%)
/maintainer/[organization]/(topbar)/finance/layout 441.34 KB 667.76 KB 190.79% (+/- <0.01%)
/maintainer/[organization]/(topbar)/finance/incoming/page 188.36 KB 414.78 KB 118.51% (+/- <0.01%)
/maintainer/[organization]/(topbar)/finance/outgoing/page 140.13 KB 366.56 KB 104.73% (+/- <0.01%)
/maintainer/[organization]/(topbar)/finance/issue-funding/page 73.02 KB 299.44 KB 85.55% (🟡 +0.01%)
/maintainer/[organization]/(topbar)/finance/issue-funding/layout 441.34 KB 667.76 KB 190.79% (+/- <0.01%)
/maintainer/[organization]/(topbar)/finance/issue-funding/rewarded/page 72.29 KB 298.71 KB 85.35% (+/- <0.01%)
/maintainer/[organization]/(topbar)/finance/issue-funding/contributors/page 72.3 KB 298.72 KB 85.35% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@frankie567 frankie567 merged commit 3857a50 into main Jul 9, 2024
11 of 12 checks passed
@frankie567 frankie567 deleted the fix/3597 branch July 9, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Products List API: include_archived is a bad filter
1 participant