Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clients/web/docs: remove Content-Type header from curl command if no body #3624

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

frankie567
Copy link
Member

No description provided.

@frankie567 frankie567 enabled auto-merge (rebase) July 9, 2024 13:42
Copy link

vercel bot commented Jul 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
polar 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 1:42pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
polar-next-js-example ⬜️ Ignored (Inspect) Jul 9, 2024 1:42pm

Copy link
Contributor

github-actions bot commented Jul 9, 2024

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 224.12 KB (🟡 +1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirty-three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/maintainer/page 446.03 KB 670.15 KB 191.47% (🟡 +0.22%)
/backoffice/layout 453.21 KB 677.33 KB 193.52% (🟡 +0.22%)
/docs/api/[...endpoint]/page 417.36 KB 641.49 KB 183.28% (🟡 +0.22%)
/maintainer/[organization]/(topbar)/layout 453.21 KB 677.33 KB 193.52% (🟡 +0.22%)
/maintainer/[organization]/(topbar)/donations/overview/page 570.41 KB 794.53 KB 227.01% (🟡 +0.22%)
/maintainer/[organization]/(topbar)/funding/page 474.32 KB 698.45 KB 199.56% (🟡 +0.22%)
/maintainer/[organization]/(topbar)/issues/badge/page 465.4 KB 689.53 KB 197.01% (🟡 +0.22%)
/maintainer/[organization]/(topbar)/issues/overview/page 481.58 KB 705.7 KB 201.63% (🟡 +0.22%)
/maintainer/[organization]/(topbar)/members/page 443.35 KB 667.47 KB 190.71% (🟡 +0.22%)
/maintainer/[organization]/(topbar)/overview/page 469.93 KB 694.06 KB 198.30% (🟡 +0.22%)
/maintainer/[organization]/(topbar)/posts/analytics/page 563.51 KB 787.63 KB 225.04% (🟡 +0.22%)
/maintainer/[organization]/(topbar)/posts/page 554.07 KB 778.19 KB 222.34% (🟡 +0.22%)
/maintainer/[organization]/(topbar)/products/benefits/page 535.28 KB 759.41 KB 216.97% (🟡 +0.22%)
/maintainer/[organization]/(topbar)/products/overview/page 472.78 KB 696.91 KB 199.12% (🟡 +0.22%)
/maintainer/[organization]/(topbar)/sales/overview/page 567 KB 791.13 KB 226.04% (🟡 +0.22%)
/maintainer/[organization]/(topbar)/sales/orders/page 475.75 KB 699.87 KB 199.96% (🟡 +0.22%)
/maintainer/[organization]/(topbar)/sales/subscriptions/page 488.61 KB 712.74 KB 203.64% (🟡 +0.22%)
/maintainer/[organization]/(topbar)/settings/page 458.88 KB 683.01 KB 195.14% (🟡 +0.23%)
/maintainer/[organization]/(topbar)/settings/webhooks/endpoints/[id]/page 485.26 KB 709.38 KB 202.68% (🟡 +0.22%)
/maintainer/[organization]/(white)/posts/[post]/page 551.01 KB 775.13 KB 221.47% (🟡 +0.22%)
/maintainer/[organization]/(white)/layout 437.88 KB 662 KB 189.14% (🟡 +0.22%)
/maintainer/[organization]/(white)/posts/new/page 548.65 KB 772.78 KB 220.79% (🟡 +0.22%)
/maintainer/[organization]/products/[id]/page 524.69 KB 748.81 KB 213.95% (🟡 +0.22%)
/maintainer/[organization]/products/layout 437.88 KB 662 KB 189.14% (🟡 +0.22%)
/maintainer/[organization]/products/new/page 524.37 KB 748.49 KB 213.86% (🟡 +0.22%)
/maintainer/[organization]/promote/page 459.86 KB 683.98 KB 195.42% (🟡 +0.22%)
/maintainer/[organization]/promote/layout 437.88 KB 662 KB 189.14% (🟡 +0.22%)
/docs/(mdx)/layout 389.62 KB 613.74 KB 175.35% (🟡 +0.23%)
/docs/api/(mdx)/layout 389.61 KB 613.73 KB 175.35% (🟡 +0.22%)
/docs/contribute/layout 389.62 KB 613.74 KB 175.35% (🟡 +0.23%)
/docs/support/layout 389.62 KB 613.74 KB 175.35% (🟡 +0.23%)
/maintainer/[organization]/(topbar)/finance/layout 437.87 KB 662 KB 189.14% (🟡 +0.22%)
/maintainer/[organization]/(topbar)/finance/issue-funding/layout 437.87 KB 662 KB 189.14% (🟡 +0.22%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@frankie567 frankie567 merged commit 0e29492 into main Jul 9, 2024
11 of 12 checks passed
@frankie567 frankie567 deleted the fix/content-type-get-requests branch July 9, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant