Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple organization from GitHub πŸ‘·β€β™‚οΈ #3657

Merged
merged 87 commits into from
Jul 23, 2024
Merged

Conversation

frankie567
Copy link
Member

@frankie567 frankie567 commented Jul 15, 2024

Big functional changes involved:

  • βœ… The concept of "personal organization" is removed.
  • βœ… GitHub organization members are no longer synced. Existing memberships in DB are preserved.
  • βœ… The is_admin flag on user organization membership is removed. If you're a member on the organization, you have write access. Existing non-admin users synced from GitHub will be removed. We may reintroduce later our own permissions system.

Copy link

vercel bot commented Jul 15, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
polar βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jul 23, 2024 1:43pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
polar-next-js-example ⬜️ Ignored (Inspect) Visit Preview Jul 23, 2024 1:43pm

Copy link
Contributor

github-actions bot commented Jul 15, 2024

πŸ“¦ Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. πŸ€–

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 226.57 KB (🟑 +45 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Pages Added

The following pages were added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350Β KB)
/maintainer/(onboarding)/create/page 99.81Β KB 326.37Β KB 93.25%
/maintainer/[organization]/(topbar)/issues/organizations/page 453.97Β KB 680.53Β KB 194.44%

One Hundred Fifty-four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350Β KB)
/not-found 44.88 KB 271.44 KB 77.55% (🟑 +0.01%)
/_not-found/page 177Β B 226.74Β KB 64.78% (+/- <0.01%)
/layout 56.12 KB 282.68 KB 80.77% (🟒 -0.10%)
/error 9.62Β KB 236.19Β KB 67.48% (+/- <0.01%)
/global-error 9.62Β KB 236.19Β KB 67.48% (+/- <0.01%)
/maintainer/page 10.39 KB 236.96 KB 67.70% (🟒 -127.38%)
/oauth2/authorize/page 35.49 KB 262.05 KB 74.87% (🟑 +0.05%)
/login/magic-link/request/page 177Β B 226.74Β KB 64.78% (+/- <0.01%)
/login/page 67.97 KB 294.53 KB 84.15% (🟑 +0.07%)
/new/page 11.12Β KB 237.69Β KB 67.91% (+/- <0.01%)
/signup/maintainer/page 37.03 KB 263.6 KB 75.31% (🟒 -0.08%)
/(installation)/github/installation/page 97.08 KB 323.65 KB 92.47% (🟑 +9.52%)
/(installation)/github/layout 177Β B 226.74Β KB 64.78% (+/- <0.01%)
/(topbar)/checkout/success/page 94.12 KB 320.69 KB 91.62% (🟒 -0.11%)
/(topbar)/layout 184.71 KB 411.28 KB 117.51% (🟑 +0.36%)
/(topbar)/not-found 44.88 KB 271.44 KB 77.55% (🟑 +0.01%)
/(topbar)/error/page 2.29Β KB 228.86Β KB 65.39% (+/- <0.01%)
/(topbar)/unsubscribe/page 31.14 KB 257.71 KB 73.63% (🟒 -0.08%)
/[organization]/(sidebar)/donate/page 197.38 KB 423.95 KB 121.13% (🟒 -0.19%)
/[organization]/(sidebar)/layout 196.8 KB 423.37 KB 120.96% (🟒 -0.11%)
/[organization]/(sidebar)/donate/status/page 39.64 KB 266.2 KB 76.06% (🟒 -0.08%)
/[organization]/(sidebar)/issues/page 128 KB 354.56 KB 101.30% (🟑 +0.18%)
/[organization]/(sidebar)/page 229.82 KB 456.38 KB 130.39% (🟒 -0.41%)
/[organization]/(sidebar)/posts/[postSlug]/page 197.03 KB 423.59 KB 121.03% (🟒 -0.17%)
/[organization]/(sidebar)/posts/page 138.58 KB 365.14 KB 104.33% (🟒 -0.10%)
/[organization]/(sidebar)/products/page 103.44 KB 330.01 KB 94.29% (🟑 +0.04%)
/[organization]/(sidebar)/products/[productId]/page 135.77 KB 362.33 KB 103.52% (🟒 -0.02%)
/[organization]/(sidebar)/repositories/page 97.34 KB 323.9 KB 92.54% (🟑 +8.53%)
/[organization]/(sidebar)/subscriptions/page 157.2 KB 383.76 KB 109.65% (🟒 -0.08%)
/[organization]/[repo]/issues/[number]/(create)/page 154.07 KB 380.63 KB 108.75% (🟒 -0.19%)
/[organization]/[repo]/layout 132.48 KB 359.05 KB 102.59% (🟑 +0.05%)
/[organization]/[repo]/issues/[number]/status/page 180.81 KB 407.37 KB 116.39% (🟒 -0.12%)
/[organization]/subscribe/page 144.02 KB 370.58 KB 105.88% (🟒 -0.16%)
/[organization]/subscribe/layout 10.39Β KB 236.96Β KB 67.70% (+/- <0.01%)
/backoffice/badge/page 52.73 KB 279.29 KB 79.80% (🟒 -0.08%)
/backoffice/layout 462.23 KB 688.8 KB 196.80% (🟒 -0.35%)
/[organization]/[repo]/page 221.72 KB 448.29 KB 128.08% (🟒 -0.25%)
/backoffice/issue/[id]/page 62.32 KB 288.88 KB 82.54% (🟒 -0.08%)
/backoffice/pledges/page 64.45 KB 291.01 KB 83.15% (🟒 -0.08%)
/backoffice/rebadge/page 39.5 KB 266.07 KB 76.02% (🟒 -0.08%)
/backoffice/rewards_pending/page 65.94 KB 292.51 KB 83.57% (🟒 -0.07%)
/maintainer/(onboarding)/[organization]/onboarding/page 123.06 KB 349.62 KB 99.89% (🟒 -0.02%)
/maintainer/(onboarding)/layout 177Β B 226.74Β KB 64.78% (+/- <0.01%)
/maintainer/[organization]/page 10.39Β KB 236.96Β KB 67.70% (+/- <0.01%)
/maintainer/[organization]/layout 10.45Β KB 237.02Β KB 67.72% (+/- <0.01%)
/backoffice/page 2.29Β KB 228.86Β KB 65.39% (+/- <0.01%)
/docs/api/[...endpoint]/page 427.43 KB 653.99 KB 186.86% (🟒 -0.25%)
/docs/layout 130.62 KB 357.19 KB 102.05% (🟒 -0.02%)
/(landing)/(features)/newsletters/page 154.27 KB 380.83 KB 108.81% (🟒 -0.03%)
/(landing)/layout 108.9 KB 335.46 KB 95.85% (🟑 +0.22%)
/(landing)/(features)/products/page 153.88 KB 380.45 KB 108.70% (🟑 +0.02%)
/(landing)/(features)/benefits/page 138.7 KB 365.27 KB 104.36% (🟒 -0.06%)
/(landing)/page 138.6 KB 365.16 KB 104.33% (🟒 -0.06%)
/(landing)/(features)/issue-funding/page 138.7 KB 365.27 KB 104.36% (🟒 -0.06%)
/(landing)/(features)/donations/page 138.7 KB 365.27 KB 104.36% (🟒 -0.06%)
/(topbar)/(backer)/purchases/page 177Β B 226.74Β KB 64.78% (+/- <0.01%)
/(topbar)/(backer)/layout 53.09 KB 279.65 KB 79.90% (🟒 -0.16%)
/(topbar)/(backer)/error 414Β B 226.97Β KB 64.85% (+/- <0.01%)
/(topbar)/(backer)/purchases/products/[id]/page 208.9 KB 435.47 KB 124.42% (🟒 -0.25%)
/(topbar)/(backer)/purchases/products/page 103.51 KB 330.08 KB 94.31% (🟑 +0.08%)
/(topbar)/(backer)/settings/page 213.04 KB 439.61 KB 125.60% (🟒 -0.69%)
/(topbar)/(backer)/purchases/subscriptions/[id]/page 210.81 KB 437.38 KB 124.97% (🟒 -0.25%)
/(topbar)/(backer)/purchases/subscriptions/page 97.14 KB 323.7 KB 92.49% (🟑 +0.13%)
/maintainer/[organization]/(topbar)/donations/donors/page 177Β B 226.74Β KB 64.78% (+/- <0.01%)
/maintainer/[organization]/(topbar)/layout 462.24 KB 688.8 KB 196.80% (🟒 -0.35%)
/maintainer/[organization]/(topbar)/donations/overview/page 579.22 KB 805.79 KB 230.23% (🟒 -0.40%)
/maintainer/[organization]/(topbar)/donations/page 177Β B 226.74Β KB 64.78% (+/- <0.01%)
/maintainer/[organization]/(topbar)/funding/page 482.84 KB 709.41 KB 202.69% (🟒 -0.48%)
/maintainer/[organization]/(topbar)/issues/badge/page 474.37 KB 700.94 KB 200.27% (🟒 -0.35%)
/maintainer/[organization]/(topbar)/initialize/page 150.23 KB 376.79 KB 107.65% (🟒 -0.11%)
/maintainer/[organization]/(topbar)/issues/overview/page 489.94 KB 716.5 KB 204.71% (🟒 -0.52%)
/maintainer/[organization]/(topbar)/overview/page 478.32 KB 704.89 KB 201.40% (🟒 -0.52%)
/maintainer/[organization]/(topbar)/members/page 447.8 KB 674.36 KB 192.67% (🟒 -1.64%)
/maintainer/[organization]/(topbar)/posts/analytics/page 572.47 KB 799.04 KB 228.30% (🟒 -0.36%)
/maintainer/[organization]/(topbar)/posts/page 562.85 KB 789.41 KB 225.55% (🟒 -0.41%)
/maintainer/[organization]/(topbar)/products/benefits/page 545.58 KB 772.15 KB 220.61% (🟒 -0.01%)
/maintainer/[organization]/(topbar)/products/overview/page 481.59 KB 708.16 KB 202.33% (🟒 -0.40%)
/maintainer/[organization]/(topbar)/sales/orders/page 484.56 KB 711.12 KB 203.18% (🟒 -0.40%)
/maintainer/[organization]/(topbar)/sales/overview/page 576 KB 802.57 KB 229.30% (🟒 -0.34%)
/maintainer/[organization]/(topbar)/sales/subscriptions/page 497.17 KB 723.73 KB 206.78% (🟒 -0.47%)
/maintainer/[organization]/(topbar)/settings/page 465.92 KB 692.48 KB 197.85% (🟒 -0.65%)
/maintainer/[organization]/(topbar)/settings/webhooks/endpoints/[id]/page 493.89 KB 720.46 KB 205.84% (🟒 -0.45%)
/maintainer/[organization]/(white)/posts/[post]/page 557.9 KB 784.46 KB 224.13% (🟒 -0.97%)
/maintainer/[organization]/(white)/layout 446.87 KB 673.43 KB 192.41% (🟒 -0.34%)
/maintainer/[organization]/(white)/posts/new/page 555.56 KB 782.13 KB 223.46% (🟒 -0.96%)
/maintainer/[organization]/products/[id]/page 533.66 KB 760.23 KB 217.21% (🟒 -0.42%)
/maintainer/[organization]/products/layout 446.87 KB 673.43 KB 192.41% (🟒 -0.34%)
/maintainer/[organization]/products/new/page 533.33 KB 759.9 KB 217.11% (🟒 -0.41%)
/maintainer/[organization]/promote/page 468.73 KB 695.29 KB 198.66% (🟒 -0.40%)
/maintainer/[organization]/promote/layout 446.87 KB 673.43 KB 192.41% (🟒 -0.34%)
/docs/(mdx)/benefits/ads/page 33.73 KB 260.3 KB 74.37% (🟑 +0.04%)
/docs/(mdx)/layout 355.31 KB 581.88 KB 166.25% (🟒 -12.92%)
/docs/(mdx)/benefits/discord/page 34.15 KB 260.72 KB 74.49% (🟑 +0.04%)
/docs/(mdx)/benefits/github-repositories/page 33.82 KB 260.38 KB 74.40% (🟑 +0.03%)
/docs/(mdx)/benefits/newsletter/page 33.7 KB 260.26 KB 74.36% (🟑 +0.04%)
/docs/(mdx)/benefits/page 31.36 KB 257.93 KB 73.69% (🟑 +0.04%)
/docs/(mdx)/benefits/file-downloads/page 34.6 KB 261.17 KB 74.62% (🟑 +0.03%)
/docs/(mdx)/customers/purchases/page 30.64 KB 257.21 KB 73.49% (🟑 +0.03%)
/docs/(mdx)/donations/page 31.99 KB 258.56 KB 73.87% (🟑 +0.04%)
/docs/(mdx)/finance/accounts/page 33.89 KB 260.45 KB 74.42% (🟑 +0.03%)
/docs/(mdx)/finance/balance/page 31.1 KB 257.67 KB 73.62% (🟑 +0.03%)
/docs/(mdx)/finance/payouts/page 30.64 KB 257.21 KB 73.49% (🟑 +0.03%)
/docs/(mdx)/github/embeds/page 31.51 KB 258.08 KB 73.74% (🟑 +0.03%)
/docs/(mdx)/github/funding-yaml/page 30.64 KB 257.21 KB 73.49% (🟑 +0.03%)
/docs/(mdx)/github/install/page 33.53 KB 260.09 KB 74.31% (🟑 +0.04%)
/docs/(mdx)/issue-funding/getting-started/page 33.28 KB 259.85 KB 74.24% (🟑 +0.04%)
/docs/(mdx)/guides/page 30.64 KB 257.21 KB 73.49% (🟑 +0.03%)
/docs/(mdx)/issue-funding/page 31.17 KB 257.74 KB 73.64% (🟑 +0.04%)
/docs/(mdx)/issue-funding/reward-contributors/page 31.42 KB 257.99 KB 73.71% (🟑 +0.04%)
/docs/(mdx)/issue-funding/workflow/page 34.95 KB 261.52 KB 74.72% (🟑 +0.04%)
/docs/(mdx)/merchant-of-record/tax/page 30.64 KB 257.21 KB 73.49% (🟑 +0.03%)
/docs/(mdx)/merchant-of-record/compliance/page 30.64 KB 257.21 KB 73.49% (🟑 +0.03%)
/docs/(mdx)/newsletters/page 33.66 KB 260.22 KB 74.35% (🟑 +0.04%)
/docs/(mdx)/newsletters/analytics/page 31.24 KB 257.8 KB 73.66% (🟑 +0.04%)
/docs/(mdx)/newsletters/publish/page 30.99 KB 257.55 KB 73.59% (🟑 +0.03%)
/docs/(mdx)/onboarding/page 59.92 KB 286.49 KB 81.85% (🟒 -0.03%)
/docs/(mdx)/page 31.09 KB 257.65 KB 73.61% (🟑 +0.04%)
/docs/(mdx)/payments-taxes/page 30.64 KB 257.21 KB 73.49% (🟑 +0.03%)
/docs/(mdx)/products/create/page 34.39 KB 260.96 KB 74.56% (🟑 +0.04%)
/docs/(mdx)/products/page 34.71 KB 261.28 KB 74.65% (🟑 +0.04%)
/docs/(mdx)/sales/orders/page 30.93 KB 257.5 KB 73.57% (🟑 +0.04%)
/docs/(mdx)/sales/subscriptions/page 30.94 KB 257.5 KB 73.57% (🟑 +0.04%)
/docs/(mdx)/sales/page 33.26 KB 259.83 KB 74.24% (🟑 +0.03%)
/docs/(mdx)/subscriptions/page 30.64 KB 257.21 KB 73.49% (🟑 +0.03%)
/docs/api/(mdx)/authentication/page 197.36 KB 423.92 KB 121.12% (🟑 +0.27%)
/docs/api/(mdx)/layout 355.31 KB 581.87 KB 166.25% (🟒 -12.92%)
/docs/api/(mdx)/github-actions/page 30.64 KB 257.21 KB 73.49% (🟑 +0.03%)
/docs/api/(mdx)/page 30.64 KB 257.21 KB 73.49% (🟑 +0.03%)
/docs/api/(mdx)/polar-sdk/page 32.92 KB 259.49 KB 74.14% (🟑 +0.03%)
/docs/api/(mdx)/webhooks/page 31.44 KB 258.01 KB 73.72% (🟑 +0.03%)
/docs/api/(mdx)/webhooks/events/page 25.71 KB 252.27 KB 72.08% (🟑 +0.06%)
/docs/support/(mdx)/faq/page 32.92 KB 259.49 KB 74.14% (🟑 +0.03%)
/docs/support/layout 355.31 KB 581.88 KB 166.25% (🟒 -12.92%)
/docs/support/(mdx)/page 30.64 KB 257.21 KB 73.49% (🟑 +0.03%)
/docs/contribute/page 32.92 KB 259.49 KB 74.14% (🟑 +0.03%)
/docs/contribute/layout 355.31 KB 581.88 KB 166.25% (🟒 -12.92%)
/(landing)/(mdx)/careers/page 30.64 KB 257.21 KB 73.49% (🟑 +0.03%)
/(landing)/(mdx)/layout 177Β B 226.74Β KB 64.78% (+/- <0.01%)
/(topbar)/(backer)/(sidebar)/feed/page 136.02 KB 362.59 KB 103.60% (🟒 -0.03%)
/(topbar)/(backer)/(sidebar)/layout 91.26Β KB 317.82Β KB 90.81% (+/- <0.01%)
/(topbar)/(backer)/(sidebar)/funding/page 201.55 KB 428.12 KB 122.32% (🟑 +0.11%)
/(topbar)/(backer)/finance/account/page 171.41 KB 397.97 KB 113.71% (🟒 -0.18%)
/(topbar)/(backer)/finance/layout 154.32 KB 380.88 KB 108.82% (🟑 +0.02%)
/(topbar)/(backer)/finance/incoming/page 186.73 KB 413.3 KB 118.08% (🟑 +0.16%)
/(topbar)/(backer)/finance/rewards/page 70.4 KB 296.97 KB 84.85% (🟒 -0.19%)
/(topbar)/(backer)/finance/outgoing/page 138.98 KB 365.55 KB 104.44% (🟑 +0.19%)
/maintainer/[organization]/(topbar)/finance/account/page 172.85 KB 399.42 KB 114.12% (🟒 -0.08%)
/maintainer/[organization]/(topbar)/finance/layout 446.86 KB 673.43 KB 192.41% (🟒 -0.34%)
/maintainer/[organization]/(topbar)/finance/incoming/page 188.42 KB 414.98 KB 118.57% (🟑 +0.23%)
/maintainer/[organization]/(topbar)/finance/outgoing/page 140.31 KB 366.87 KB 104.82% (🟑 +0.27%)
/maintainer/[organization]/(topbar)/finance/issue-funding/contributors/page 71.88 KB 298.44 KB 85.27% (🟒 -0.11%)
/maintainer/[organization]/(topbar)/finance/issue-funding/layout 446.86 KB 673.43 KB 192.41% (🟒 -0.34%)
/maintainer/[organization]/(topbar)/finance/issue-funding/rewarded/page 71.87 KB 298.44 KB 85.27% (🟒 -0.11%)
/maintainer/[organization]/(topbar)/finance/issue-funding/page 72.6 KB 299.16 KB 85.47% (🟒 -0.10%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@frankie567 frankie567 merged commit 5648315 into main Jul 23, 2024
12 checks passed
@frankie567 frankie567 deleted the fix/3654 branch July 23, 2024 14:23
Copy link

sentry-io bot commented Jul 23, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ValueError: no external organization found or not linked to a Polar organization github.repo.sync.pull_requests View Issue
  • ‼️ ValueError: no external organization found or not linked to a Polar organization github.repo.sync.issues View Issue
  • ‼️ ValueError: no repository found github.repo.sync.pull_requests View Issue
  • ‼️ ValueError: no repository found github.repo.sync.issues View Issue
  • ‼️ PrimaryRateLimitExceeded: (Response(403, data_model=typing.Any), datetime.timedelta(0)) polar.issue.endpoints.get_body View Issue

Did you find this useful? React with a πŸ‘ or πŸ‘Ž

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant