Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polar Page: Customize Free Subscription Promotion & Counting #3658

Merged
merged 8 commits into from
Jul 16, 2024

Conversation

birkjernstrom
Copy link
Member

@birkjernstrom birkjernstrom commented Jul 15, 2024

Screen.Recording.2024-07-16.at.11.03.49.mov

Give creators more control over how to promote subscriptions on their Polar page.

  • Show/hide Subscribe with Email and subsequently the Free tier on the Subscriptions page

  • Show/hide the public count/display of active subscribers

  • Include/exclude free subscribers in the total count of active subscribers

  • Fixes Pages: Show paid subscribers separately #2818

Leverage the same profile_settings in the Subscribe embed badge to reflect the same count.

Copy link

vercel bot commented Jul 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
polar ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 9:07am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
polar-next-js-example ⬜️ Ignored (Inspect) Visit Preview Jul 16, 2024 9:07am

@birkjernstrom birkjernstrom changed the title page: Customize subscription promotion Polar Page: Customize Free Subscription Promotion & Counting Jul 15, 2024
Copy link
Contributor

github-actions bot commented Jul 16, 2024

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 226.52 KB (🟡 +1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Ninety-five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/layout 56.46 KB 282.98 KB 80.85% (🟡 +0.01%)
/maintainer/page 455.99 KB 682.52 KB 195.00% (🟡 +0.02%)
/login/page 67.72 KB 294.24 KB 84.07% (🟡 +0.01%)
/signup/maintainer/page 37.31 KB 263.83 KB 75.38% (🟡 +0.01%)
/(installation)/github/installation/page 63.78 KB 290.3 KB 82.94% (🟡 +0.01%)
/(topbar)/checkout/success/page 94.53 KB 321.05 KB 91.73% (🟡 +0.01%)
/(topbar)/layout 183.39 KB 409.91 KB 117.12% (🟡 +0.01%)
/(topbar)/unsubscribe/page 31.42 KB 257.94 KB 73.70% (🟡 +0.01%)
/[organization]/(sidebar)/donate/page 198.03 KB 424.55 KB 121.30% (🟡 +0.02%)
/[organization]/(sidebar)/layout 197.21 KB 423.73 KB 121.07% (🟡 +1.30%)
/[organization]/(sidebar)/donate/status/page 39.92 KB 266.45 KB 76.13% (🟡 +0.01%)
/[organization]/(sidebar)/issues/page 127.37 KB 353.89 KB 101.11% (🟡 +0.01%)
/[organization]/(sidebar)/page 231.26 KB 457.79 KB 130.80% (🟡 +0.02%)
/[organization]/(sidebar)/posts/[postSlug]/page 197.6 KB 424.12 KB 121.18% (🟡 +0.01%)
/[organization]/(sidebar)/posts/page 138.92 KB 365.44 KB 104.41% (🟡 +0.01%)
/[organization]/(sidebar)/products/[productId]/page 135.84 KB 362.36 KB 103.53% (🟡 +0.01%)
/[organization]/(sidebar)/products/page 103.3 KB 329.82 KB 94.23% (🟡 +0.01%)
/[organization]/(sidebar)/repositories/page 67.48 KB 294 KB 84.00% (🟡 +0.01%)
/[organization]/(sidebar)/subscriptions/page 157.47 KB 384 KB 109.71% (🟢 -0.01%)
/[organization]/[repo]/issues/[number]/(create)/page 154.73 KB 381.25 KB 108.93% (🟡 +0.01%)
/[organization]/[repo]/layout 132.28 KB 358.8 KB 102.52% (🟡 +0.01%)
/[organization]/[repo]/issues/[number]/status/page 181.24 KB 407.76 KB 116.50% (🟡 +0.01%)
/[organization]/[repo]/page 222.61 KB 449.13 KB 128.32% (🟡 +0.01%)
/[organization]/subscribe/page 144.59 KB 371.12 KB 106.03% (🟡 +0.01%)
/backoffice/issue/[id]/page 62.59 KB 289.11 KB 82.60% (🟡 +0.01%)
/backoffice/layout 463.19 KB 689.71 KB 197.06% (🟡 +0.01%)
/backoffice/badge/page 53 KB 279.52 KB 79.86% (🟡 +0.01%)
/backoffice/pledges/page 64.72 KB 291.24 KB 83.21% (🟡 +0.01%)
/backoffice/rebadge/page 39.78 KB 266.3 KB 76.09% (🟡 +0.01%)
/backoffice/rewards_pending/page 66.21 KB 292.73 KB 83.64% (🟡 +0.01%)
/maintainer/(onboarding)/[organization]/onboarding/page 123.13 KB 349.65 KB 99.90% (🟡 +0.01%)
/docs/api/[...endpoint]/page 428.04 KB 654.57 KB 187.02% (🟡 +0.01%)
/docs/layout 130.69 KB 357.21 KB 102.06% (🟡 +0.01%)
/(landing)/(features)/donations/page 138.91 KB 365.43 KB 104.41% (🟡 +0.01%)
/(landing)/(features)/benefits/page 138.91 KB 365.43 KB 104.41% (🟡 +0.01%)
/(landing)/(features)/issue-funding/page 138.91 KB 365.43 KB 104.41% (🟡 +0.01%)
/(landing)/(features)/newsletters/page 154.37 KB 380.89 KB 108.83% (🟡 +0.01%)
/(landing)/page 138.81 KB 365.33 KB 104.38% (🟡 +0.01%)
/(landing)/(features)/products/page 153.79 KB 380.31 KB 108.66% (🟡 +0.01%)
/(topbar)/(backer)/purchases/products/[id]/page 209.76 KB 436.28 KB 124.65% (🟡 +0.01%)
/(topbar)/(backer)/layout 53.66 KB 280.18 KB 80.05% (🟡 +0.01%)
/(topbar)/(backer)/purchases/products/page 103.24 KB 329.76 KB 94.22% (🟡 +0.01%)
/(topbar)/(backer)/purchases/subscriptions/[id]/page 211.67 KB 438.19 KB 125.20% (🟡 +0.01%)
/(topbar)/(backer)/purchases/subscriptions/page 96.65 KB 323.18 KB 92.34% (🟡 +0.01%)
/(topbar)/(backer)/settings/page 215.46 KB 441.98 KB 126.28% (🟡 +0.01%)
/maintainer/[organization]/(topbar)/layout 463.19 KB 689.71 KB 197.06% (🟡 +0.01%)
/maintainer/[organization]/(topbar)/donations/overview/page 580.39 KB 806.92 KB 230.55% (🟡 +0.01%)
/maintainer/[organization]/(topbar)/funding/page 484.29 KB 710.81 KB 203.09% (🟡 +0.01%)
/maintainer/[organization]/(topbar)/initialize/page 150.62 KB 377.14 KB 107.75% (🟡 +0.01%)
/maintainer/[organization]/(topbar)/issues/overview/page 491.55 KB 718.07 KB 205.16% (🟡 +0.01%)
/maintainer/[organization]/(topbar)/issues/badge/page 475.37 KB 701.89 KB 200.54% (🟡 +0.01%)
/maintainer/[organization]/(topbar)/members/page 453.32 KB 679.84 KB 194.24% (🟡 +0.01%)
/maintainer/[organization]/(topbar)/overview/page 479.91 KB 706.43 KB 201.84% (🟡 +0.01%)
/maintainer/[organization]/(topbar)/posts/analytics/page 573.5 KB 800.02 KB 228.58% (🟡 +0.01%)
/maintainer/[organization]/(topbar)/posts/page 564.05 KB 790.58 KB 225.88% (🟡 +0.01%)
/maintainer/[organization]/(topbar)/products/benefits/page 545.41 KB 771.93 KB 220.55% (🟡 +0.01%)
/maintainer/[organization]/(topbar)/products/overview/page 482.76 KB 709.28 KB 202.65% (🟡 +0.01%)
/maintainer/[organization]/(topbar)/sales/overview/page 576.99 KB 803.51 KB 229.57% (🟡 +0.01%)
/maintainer/[organization]/(topbar)/sales/subscriptions/page 498.59 KB 725.11 KB 207.18% (🟡 +0.01%)
/maintainer/[organization]/(topbar)/settings/page 467.98 KB 694.5 KB 198.43% (🟡 +0.01%)
/maintainer/[organization]/(topbar)/sales/orders/page 485.72 KB 712.24 KB 203.50% (🟡 +0.01%)
/maintainer/[organization]/(white)/posts/[post]/page 561 KB 787.52 KB 225.01% (🟡 +0.01%)
/maintainer/[organization]/(white)/layout 447.83 KB 674.36 KB 192.67% (🟡 +0.01%)
/maintainer/[organization]/(topbar)/settings/webhooks/endpoints/[id]/page 495.25 KB 721.77 KB 206.22% (🟡 +0.01%)
/maintainer/[organization]/(white)/posts/new/page 558.64 KB 785.16 KB 224.33% (🟡 +0.01%)
/maintainer/[organization]/products/new/page 534.51 KB 761.03 KB 217.44% (🟡 +0.01%)
/maintainer/[organization]/products/layout 447.83 KB 674.35 KB 192.67% (🟡 +0.01%)
/maintainer/[organization]/products/[id]/page 534.82 KB 761.34 KB 217.53% (🟡 +0.01%)
/maintainer/[organization]/promote/page 469.83 KB 696.35 KB 198.96% (🟡 +0.01%)
/maintainer/[organization]/promote/layout 447.83 KB 674.36 KB 192.67% (🟡 +0.01%)
/docs/(mdx)/layout 400.3 KB 626.82 KB 179.09% (🟡 +0.01%)
/docs/(mdx)/finance/payouts/page 30.52 KB 257.04 KB 73.44% (+/- <0.01%)
/docs/(mdx)/onboarding/page 60.05 KB 286.57 KB 81.88% (🟡 +0.01%)
/docs/api/(mdx)/layout 400.29 KB 626.82 KB 179.09% (🟡 +0.01%)
/docs/api/(mdx)/authentication/page 196.43 KB 422.95 KB 120.84% (🟡 +0.01%)
/docs/contribute/layout 400.3 KB 626.82 KB 179.09% (🟡 +0.01%)
/docs/support/layout 400.3 KB 626.82 KB 179.09% (🟡 +0.01%)
/(topbar)/(backer)/(sidebar)/funding/page 201.18 KB 427.7 KB 122.20% (🟡 +0.01%)
/(topbar)/(backer)/(sidebar)/layout 91.24 KB 317.76 KB 90.79% (🟡 +0.01%)
/(topbar)/(backer)/(sidebar)/feed/page 136.11 KB 362.63 KB 103.61% (🟡 +0.01%)
/(topbar)/(backer)/finance/account/page 172.04 KB 398.56 KB 113.87% (🟡 +0.01%)
/(topbar)/(backer)/finance/layout 154.21 KB 380.73 KB 108.78% (🟡 +0.01%)
/(topbar)/(backer)/finance/incoming/page 186.19 KB 412.72 KB 117.92% (🟡 +0.01%)
/(topbar)/(backer)/finance/outgoing/page 138.32 KB 364.84 KB 104.24% (🟡 +0.01%)
/(topbar)/(backer)/finance/issue-funding/page 71.55 KB 298.07 KB 85.16% (🟡 +0.01%)
/(topbar)/(backer)/finance/rewards/page 71.05 KB 297.57 KB 85.02% (🟡 +0.01%)
/(topbar)/(backer)/finance/issue-funding/contributors/page 70.96 KB 297.49 KB 85.00% (🟡 +0.01%)
/maintainer/[organization]/(topbar)/finance/account/page 173.14 KB 399.66 KB 114.19% (🟡 +0.01%)
/maintainer/[organization]/(topbar)/finance/layout 447.83 KB 674.35 KB 192.67% (🟡 +0.01%)
/maintainer/[organization]/(topbar)/finance/incoming/page 187.59 KB 414.11 KB 118.32% (🟡 +0.01%)
/maintainer/[organization]/(topbar)/finance/outgoing/page 139.37 KB 365.89 KB 104.54% (🟡 +0.01%)
/maintainer/[organization]/(topbar)/finance/issue-funding/page 72.97 KB 299.49 KB 85.57% (🟡 +0.01%)
/maintainer/[organization]/(topbar)/finance/issue-funding/layout 447.83 KB 674.35 KB 192.67% (🟡 +0.01%)
/maintainer/[organization]/(topbar)/finance/issue-funding/contributors/page 72.25 KB 298.77 KB 85.36% (🟡 +0.01%)
/maintainer/[organization]/(topbar)/finance/issue-funding/rewarded/page 72.25 KB 298.77 KB 85.36% (🟡 +0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@birkjernstrom birkjernstrom marked this pull request as ready for review July 16, 2024 09:07
@birkjernstrom birkjernstrom merged commit 240e1d7 into main Jul 16, 2024
12 checks passed
@birkjernstrom birkjernstrom deleted the polarpage/paid-subscribers branch July 16, 2024 09:07
Copy link

sentry-io bot commented Jul 16, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ResponseError: Response returned an error code BaseAPI._BaseAPI.request(server/packages/sdk/di... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide 'Free' Users in ReadMe Badges Pages: Show paid subscribers separately
1 participant