Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RegionX Cocos #10696

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Add RegionX Cocos #10696

merged 4 commits into from
Jul 1, 2024

Conversation

Szegoo
Copy link
Contributor

@Szegoo Szegoo commented Jun 23, 2024

This PR is a request to add the RegionX test parachain called 'Cocos' to Polkadot.js.

@Szegoo Szegoo marked this pull request as draft June 24, 2024 08:51
@Szegoo Szegoo marked this pull request as draft June 24, 2024 08:51
@Szegoo Szegoo marked this pull request as ready for review June 24, 2024 09:02
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the ordering just needs to be updated:

Test networks:: RegionX Cocos needs to be before Rhala Testnet

@Szegoo
Copy link
Contributor Author

Szegoo commented Jun 27, 2024

@TarikGul I updated the order

Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like another ordering issues, It is kind of silly but it does 1 level at a time, so maybe run yarn test locally after fixing it or try to see where the it should be manually in the order.

@Szegoo
Copy link
Contributor Author

Szegoo commented Jun 29, 2024

@TarikGul Checked with yarn test locally, should be good now.

@TarikGul TarikGul merged commit ad79a99 into polkadot-js:master Jul 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants