-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition from manifest v2 to v3 #1367
base: master
Are you sure you want to change the base?
Conversation
So far the extension is working fine in chrome with the exception of the following errors:
|
Instead of causing breaking changes to Edit: Ahh but this might not work since there is no more persistent background. |
edit: There was a stray change in the current state to avoid a - const NOTIFICATION_URL = chrome.extension.getURL('notification.html');
+ const NOTIFICATION_URL = chrome.runtime.getURL('notification.html'); I had a quick look on Firefox, changing the manifest to make it happy with what I found here which I'm sure you know
edit2: In Firefox the extension is then loaded correctly, I could add an account, but no script is injected on pages, so Dapps don't detect the extensions. On chrome/brave, the next error I encountered in
|
@Tbaut Yea the I was able to fix the localStorage error but then reverted my changes because I would like to change the design of the implementation, but yea the localStorage issue will be fixed soon :) |
Is it expected that this PR will be merged in the near future? We have a downstream dependency for our Polymesh Wallet which requires this in order to move to manifest V3. @Tbaut |
Yes this is absolutely a priority! My goal is to get it done this week. |
closes: #1316
closes: #310
[WIP]
This PR has a lot left to fix, and test between firefox and chrome. A more thorough deccription will be provided as I work through all the errors that are present in the build.