perf(cache): improvements

.codacy.yml

@@ -9,5 +9,4 @@ exclude_paths:
   - src/public/js/plugins/**/*
   - src/public/js/vendor/**
   - src/public/js/vendor/**/*
-  - test/**/*
-  - src/cache/node-cache.js
+  - test/**/*

app.js

@@ -193,12 +193,7 @@ function launchServer (db) {
         //   return next()
         // },
         function (next) {
-          var NodeCache = require('./src/cache/node-cache')
-          global.cache = new NodeCache({ checkperiod: 0 })
-          var fork = require('child_process').fork
-          var memLimit = nconf.get('memlimit') || '2048'
-
-          var env = { FORK: 1, NODE_ENV: global.env }
+          var cache = require('./src/cache/cache')
           if (isDocker) {
             var envDocker = {
               TRUDESK_DOCKER: process.env.TRUDESK_DOCKER,
@@ -209,21 +204,10 @@ function launchServer (db) {
               TD_MONGODB_DATABASE: process.env.TD_MONGODB_DATABASE
             }
 
-            env = _.merge(env, envDocker)
+            cache.env = envDocker
           }
 
-          var n = fork(path.join(__dirname, '/src/cache/index.js'), {
-            execArgv: ['--max-old-space-size=' + memLimit],
-            env: env
-          })
-
-          global.forks.push({ name: 'cache', fork: n })
-
-          n.on('message', function (data) {
-            if (data.cache) {
-              global.cache.data = data.cache.data
-            }
-          })
+          cache.init()
 
           return next()
         },

src/backup/backup.js

@@ -39,7 +39,7 @@ winston.add(winston.transports.Console, {
       ' ' +
       date.toTimeString().substr(0, 8) +
       ' [Child:Backup:' +
-      global.process.pid +
+      process.pid +
       ']'
     )
   },

src/backup/restore.js

@@ -41,7 +41,7 @@ winston.add(winston.transports.Console, {
       ' ' +
       date.toTimeString().substr(0, 8) +
       ' [Child:Backup:' +
-      global.process.pid +
+      process.pid +
       ']'
     )
   },

src/cache/cache.js

@@ -0,0 +1,53 @@
+/*
+ *       .                             .o8                     oooo
+ *    .o8                             "888                     `888
+ *  .o888oo oooo d8b oooo  oooo   .oooo888   .ooooo.   .oooo.o  888  oooo
+ *    888   `888""8P `888  `888  d88' `888  d88' `88b d88(  "8  888 .8P'
+ *    888    888      888   888  888   888  888ooo888 `"Y88b.   888888.
+ *    888 .  888      888   888  888   888  888    .o o.  )88b  888 `88b.
+ *    "888" d888b     `V88V"V8P' `Y8bod88P" `Y8bod8P' 8""888P' o888o o888o
+ *  ========================================================================
+ *  Author:     Chris Brame
+ *  Updated:    5/17/19 2:03 AM
+ *  Copyright (c) 2014-2019. All rights reserved.
+ */
+
+var _ = require('lodash')
+var NodeCache = require('node-cache')
+var path = require('path')
+var cache = {}
+
+cache.init = function () {
+  global.cache = new NodeCache({ checkperiod: 0 })
+  cache.memLimit = process.env.CACHE_MEMLIMIT || '2048'
+  var env = { FORK: 1, NODE_ENV: global.env }
+  cache.env = _.merge(cache.env, env)
+
+  spawnCache()
+  setInterval(spawnCache, 55 * 60 * 1000)
+}
+
+function spawnCache () {
+  var fork = require('child_process').fork
+  console.log(cache.env)
+  var n = fork(path.join(__dirname, './index.js'), {
+    execArgv: ['--max-old-space-size=' + cache.memLimit],
+    env: cache.env
+  })
+
+  global.forks.push({ name: 'cache', fork: n })
+
+  n.on('message', function (data) {
+    if (data.cache) {
+      global.cache.data = data.cache.data
+    }
+  })
+
+  n.on('close', function () {
+    _.remove(global.forks, function (i) {
+      return i.name === 'cache'
+    })
+  })
+}
+
+module.exports = cache

src/cache/index.js

@@ -39,7 +39,7 @@ winston.add(winston.transports.Console, {
       ' ' +
       date.toTimeString().substr(0, 8) +
       ' [Child:Cache:' +
-      global.process.pid +
+      process.pid +
       ']'
     )
   },
@@ -66,7 +66,7 @@ truCache.init = function (callback) {
 
   truCache.refreshCache(function () {
     winston.debug('Cache Loaded')
-    restartRefreshClock()
+    // restartRefreshClock()
 
     return callback()
   })
@@ -103,9 +103,7 @@ truCache.refreshCache = function (callback) {
           [
             function (done) {
               var ticketStats = require('./ticketStats')
-              // console.time('test');
               ticketStats(tickets, function (err, stats) {
-                // console.timeEnd('test');
                 if (err) return done(err)
                 var expire = 3600 // 1 hour
                 cache.set('tickets:overview:lastUpdated', stats.lastUpdated, expire)
@@ -135,11 +133,6 @@ truCache.refreshCache = function (callback) {
                 cache.set('tickets:overview:e365:responseTime', stats.e365.avgResponse, expire)
                 cache.set('tickets:overview:e365:graphData', stats.e365.graphData, expire)
 
-                // cache.set('tickets:overview:lifetime:ticketCount', stats.lifetime.tickets, expire);
-                // cache.set('tickets:overview:lifetime:closedTickets', stats.lifetime.closedTickets, expire);
-                // cache.set('tickets:overview:lifetime:responseTime', stats.lifetime.avgResponse, expire);
-                // cache.set('tickets:overview:lifetime:graphData', stats.lifetime.graphData, expire);
-
                 return done()
               })
             },
@@ -232,7 +225,9 @@ truCache.refreshCache = function (callback) {
       if (err) return winston.warn(err)
       // Send to parent
       process.send({ cache: cache })
+
       cache.flushAll()
+
       if (_.isFunction(callback)) {
         return callback(err)
       }
@@ -278,6 +273,8 @@ truCache.refreshCache = function (callback) {
         winston.error(err)
         throw new Error(err)
       }
+
+      return process.exit(0)
     })
   })
 })()