Minor Improvements and Adjustments (#512)

NOTICE

@@ -1,5 +1,5 @@
 Polypheny-DB
-Copyright 2017-2022 The Polypheny Project
+Copyright 2017-2024 The Polypheny Project
 
 This product includes software developed at
 The Apache Software Foundation (http://www.apache.org/).
@@ -11,4 +11,4 @@ under the auspices of the Eigenbase Foundation
 and released as the LucidDB project.
 
 Polypheny-DB is a research system that emerged from the 
-University of Basel, Switzerland.
+University of Basel, Switzerland.

README.md

@@ -26,14 +26,13 @@ Please note that we have a [code of conduct](https://github.com/polypheny/Admin/
 ## Credits ##
 _Polypheny-DB_ builds upon the great work of several other projects:
 
-* [Apache Avatica](https://calcite.apache.org/avatica/): A framework for building database drivers
 * [Apache Calcite](https://calcite.apache.org/): A framework for building databases
 * [HSQLDB](http://hsqldb.org/): A relational database written in Java
 * [JavaCC](https://javacc.org/): A parser generator
 * [Javalin](https://javalin.io/): A framework for building web services
 * [Project Lombok](https://projectlombok.org/): A library which provides annotations for tedious tasks
 
-Except for the first two, those projects are used "as is" and integrated as a library. _Apache Avatica_ we [forked](https://github.com/polypheny/Avatica) and made some Polypheny-DB specific adjustments. From _Apache Calcite_ we use parts of the code as foundation for Polypheny-DB.
+Except for _Apache Calcite, those projects are used "as is" and are integrated as libraries. From _Apache Calcite_ we used parts of the code as foundation for Polypheny-DB.
 
 ## Acknowledgements
 The Polypheny-DB project is supported by the Swiss National Science Foundation (SNSF) under the contract no. 200021_172763.

config/src/main/java/org/polypheny/db/config/ConfigScalar.java

@@ -38,4 +38,5 @@ protected ConfigScalar( final String key ) {
     protected ConfigScalar( final String key, final String description ) {
         super( key, description );
     }
-}
+
+}

config/src/main/java/org/polypheny/db/config/exception/ConfigRuntimeException.java

@@ -25,4 +25,5 @@ public class ConfigRuntimeException extends RuntimeException {
     public ConfigRuntimeException( String msg ) {
         super( msg );
     }
+
 }

core/src/main/java/org/polypheny/db/adapter/ConnectionMethod.java

@@ -21,6 +21,7 @@ public enum ConnectionMethod {
     LINK,
     UPLOAD;
 
+
     public static ConnectionMethod from( String name ) {
         return ConnectionMethod.valueOf( name.toUpperCase() );
     }

core/src/main/java/org/polypheny/db/adapter/DocumentModifyDelegate.java

@@ -42,6 +42,7 @@ public AlgNode getGraphModify( long allocId, LpgModify<?> modify, AlgBuilder bui
         return Modifiable.getGraphModifySubstitute( modifiable, allocId, modify, builder );
     }
 
+
     @Override
     public void addColumn( Context context, long allocId, LogicalColumn column ) {
         modifiable.addColumn( context, allocId, column );

core/src/main/java/org/polypheny/db/adapter/RelationalModifyDelegate.java

@@ -126,5 +126,4 @@ public void dropCollection( Context context, AllocationCollection allocation ) {
     }
 
 
-
 }

core/src/main/java/org/polypheny/db/adapter/Scannable.java

@@ -250,7 +250,7 @@ static void dropCollectionSubstitute( Scannable scannable, Context context, Allo
     void renameLogicalColumn( long id, String newColumnName );
 
 
-    record ColumnContext(String name, Integer precision, PolyType type, boolean nullable) {
+    record ColumnContext( String name, Integer precision, PolyType type, boolean nullable ) {
 
     }
 

core/src/main/java/org/polypheny/db/adapter/java/Array.java

@@ -62,5 +62,5 @@
      * Maximum number of elements in the array. -1 means no maximum.
      */
     long maximumCardinality() default -1L;
-}
 
+}

core/src/main/java/org/polypheny/db/adapter/java/Map.java

@@ -67,5 +67,5 @@
      * Whether values may be null.
      */
     boolean valueIsNullable() default true;
-}
 
+}

core/src/main/java/org/polypheny/db/adapter/java/package-info.java

@@ -1,7 +1,5 @@
-
 /**
  * Query provider based on Java in-memory data structures.
  */
 
 package org.polypheny.db.adapter.java;
-

core/src/main/java/org/polypheny/db/adapter/package-info.java

@@ -1,7 +1,5 @@
-
 /**
  * Polypheny-DB adapters.
  */
 
 package org.polypheny.db.adapter;
-

core/src/main/java/org/polypheny/db/algebra/AlgStructuredTypeFlattener.java

@@ -945,7 +945,6 @@ public interface SelfFlatteningAlg extends AlgNode {
     private class RewriteAlgVisitor extends AlgVisitor {
 
 
-
         @Override
         public void visit( AlgNode p, int ordinal, AlgNode parent ) {
             // Rewrite children first
@@ -1097,4 +1096,3 @@ private RexNode flattenComparison( RexBuilder rexBuilder, Operator op, List<RexN
     }
 
 }
-

core/src/main/java/org/polypheny/db/algebra/convert/package-info.java

@@ -1,4 +1,3 @@
-
 /**
  * Defines relational expressions and rules for converting between calling conventions.
  */

core/src/main/java/org/polypheny/db/algebra/core/Calc.java

@@ -112,7 +112,6 @@ public boolean isValid( Litmus litmus, Context context ) {
     }
 
 
-
     @Override
     public double estimateTupleCount( AlgMetadataQuery mq ) {
         return AlgMdUtil.estimateFilteredRows( getInput(), program, mq );

core/src/main/java/org/polypheny/db/algebra/core/Match.java

@@ -330,7 +330,6 @@ public Object visitCall( RexCall call ) {
         }
 
 
-
         public Set<String> go( List<RexNode> rexNodeList ) {
             for ( RexNode rex : rexNodeList ) {
                 rex.accept( this );
@@ -364,4 +363,3 @@ public int compareTo( RexMRAggCall o ) {
     }
 
 }
-

core/src/main/java/org/polypheny/db/algebra/enumerable/AggAddContext.java

@@ -54,5 +54,5 @@ public interface AggAddContext extends AggResultContext {
      * @return {@link RexToLixTranslator} suitable to transform the arguments
      */
     RexToLixTranslator rowTranslator();
-}
 
+}

core/src/main/java/org/polypheny/db/algebra/enumerable/AggImplementor.java

@@ -79,4 +79,5 @@ public interface AggImplementor {
      * @return Expression that is a result of calculating final value of the aggregate being implemented
      */
     Expression implementResult( AggContext info, AggResultContext result );
+
 }

core/src/main/java/org/polypheny/db/algebra/enumerable/AggResetContext.java

@@ -35,5 +35,5 @@ public interface AggResetContext extends NestedBlockBuilder {
      * @see AggImplementor#getStateType(AggContext)
      */
     List<Expression> accumulator();
-}
 
+}

core/src/main/java/org/polypheny/db/algebra/enumerable/AggregateLambdaFactory.java

@@ -43,4 +43,5 @@ public interface AggregateLambdaFactory<TSource, TOrigAccumulate, TAccumulate, T
     Function1<TAccumulate, TResult> singleGroupResultSelector( Function1<TOrigAccumulate, TResult> resultSelector );
 
     Function2<TKey, TAccumulate, TResult> resultSelector( Function2<TKey, TOrigAccumulate, TResult> resultSelector );
+
 }

core/src/main/java/org/polypheny/db/algebra/enumerable/CallImplementor.java

@@ -40,5 +40,5 @@ public interface CallImplementor {
      * @return Translated call
      */
     Expression implement( RexToLixTranslator translator, RexCall call, RexImpTable.NullAs nullAs );
-}
 
+}

core/src/main/java/org/polypheny/db/algebra/enumerable/EnumerableAlg.java

@@ -113,9 +113,8 @@ public Prefer of( JavaTupleFormat format ) {
      *
      * @param physType Describes the Java type returned by this relational expression, and the mapping between it and the fields of the logical row type.
      */
-    record Result(BlockStatement block, PhysType physType, JavaTupleFormat format) {
+    record Result( BlockStatement block, PhysType physType, JavaTupleFormat format ) {
 
     }
 
 }
-

core/src/main/java/org/polypheny/db/algebra/enumerable/EnumerableWindow.java

@@ -109,7 +109,7 @@ public AlgOptCost computeSelfCost( AlgPlanner planner, AlgMetadataQuery mq ) {
     /**
      * Implementation of {@link RexToLixTranslator.InputGetter} suitable for generating implementations of windowed aggregate functions.
      */
-    private record WindowRelInputGetter(Expression row, PhysType rowPhysType, int actualInputFieldCount, List<Expression> constants) implements RexToLixTranslator.InputGetter {
+    private record WindowRelInputGetter( Expression row, PhysType rowPhysType, int actualInputFieldCount, List<Expression> constants ) implements RexToLixTranslator.InputGetter {
 
 
         @Override
@@ -843,4 +843,3 @@ private Expression translateBound(
     }
 
 }
-

core/src/main/java/org/polypheny/db/algebra/enumerable/NestedBlockBuilder.java

@@ -90,5 +90,5 @@ public interface NestedBlockBuilder {
      * @see #nestBlock()
      */
     void exitBlock();
-}
 
+}

core/src/main/java/org/polypheny/db/algebra/enumerable/NestedBlockBuilderImpl.java

@@ -146,5 +146,5 @@ public final void exitBlock() {
         blocks.remove( blocks.size() - 1 );
         nullables.remove( nullables.size() - 1 );
     }
-}
 
+}

core/src/main/java/org/polypheny/db/algebra/enumerable/OrderedAggregateLambdaFactory.java

@@ -122,7 +122,7 @@ private void add( TSource source ) {
         public @NotNull Iterator<TSource> iterator() {
             return list.iterator();
         }
+
     }
 
 }
-

core/src/main/java/org/polypheny/db/algebra/enumerable/SequencedAdderAggregateLambdaFactory.java

@@ -105,5 +105,7 @@ public TAccumulate apply( TAccumulate accumulator, TSource source ) {
             }
             return result;
         }
+
     }
+
 }

core/src/main/java/org/polypheny/db/algebra/enumerable/SourceSorter.java

@@ -71,5 +71,5 @@ public void sortAndAccumulate( Iterable<TSource> sourceIterable, TAccumulate acc
             accumulator1 = accumulatorAdder.apply( accumulator1, source );
         }
     }
-}
 
+}

core/src/main/java/org/polypheny/db/algebra/enumerable/StrictWinAggImplementor.java

@@ -105,5 +105,5 @@ protected final Expression implementNotNullResult( AggContext info, AggResultCon
     public boolean needCacheWhenFrameIntact() {
         return true;
     }
-}
 
+}

core/src/main/java/org/polypheny/db/algebra/enumerable/WinAggAddContext.java

@@ -55,5 +55,5 @@ public interface WinAggAddContext extends AggAddContext, WinAggResultContext {
      * @see WinAggFrameContext#startIndex()
      */
     Expression currentPosition();
-}
 
+}

core/src/main/java/org/polypheny/db/algebra/enumerable/WinAggFrameContext.java

@@ -86,5 +86,5 @@ public interface WinAggFrameContext {
      * @return number of rows in the current partition or 0 if the partition is empty
      */
     Expression getPartitionRowCount();
-}
 
+}

core/src/main/java/org/polypheny/db/algebra/enumerable/WinAggFrameResultContext.java

@@ -83,5 +83,5 @@ public interface WinAggFrameResultContext extends WinAggFrameContext {
      * @return result of comparison as as in {@link Comparable#compareTo}
      */
     Expression compareRows( Expression a, Expression b );
-}
 
+}

core/src/main/java/org/polypheny/db/algebra/enumerable/WinAggImplementor.java

@@ -78,5 +78,5 @@ enum SeekType {
     }
 
     boolean needCacheWhenFrameIntact();
-}
 
+}

core/src/main/java/org/polypheny/db/algebra/enumerable/WinAggResultContext.java

@@ -60,5 +60,5 @@ public interface WinAggResultContext extends AggResultContext, WinAggFrameResult
      * @return Linq4j form of arguments of the particular row
      */
     List<Expression> arguments( Expression rowIndex );
-}
 
+}

core/src/main/java/org/polypheny/db/algebra/enumerable/impl/WinAggAddContextImpl.java

@@ -48,4 +48,5 @@ public final RexToLixTranslator rowTranslator() {
     public final List<Expression> arguments() {
         return rowTranslator().translateList( rexArguments() );
     }
+
 }

core/src/main/java/org/polypheny/db/algebra/enumerable/impl/WinAggResetContextImpl.java

@@ -101,5 +101,5 @@ public Expression getFrameRowCount() {
     public Expression getPartitionRowCount() {
         return partitionRowCount;
     }
-}
 
+}

core/src/main/java/org/polypheny/db/algebra/enumerable/impl/WinAggResultContextImpl.java

@@ -122,5 +122,5 @@ public Expression getFrameRowCount() {
     public Expression getPartitionRowCount() {
         return getFrame().getPartitionRowCount();
     }
-}
 
+}

core/src/main/java/org/polypheny/db/algebra/externalize/package-info.java

@@ -1,7 +1,5 @@
-
 /**
  * Facilities to externalize {@link org.polypheny.db.algebra.AlgNode}s to and from XML and JSON format.
  */
 
 package org.polypheny.db.algebra.externalize;
-

core/src/main/java/org/polypheny/db/algebra/fun/TrimFunction.java

@@ -36,6 +36,7 @@ interface TrimFlagHolder {
 
         @Nullable
         Flag getFlag();
+
     }
 
 }

core/src/main/java/org/polypheny/db/algebra/logical/common/LogicalStreamer.java

@@ -58,7 +58,7 @@ public class LogicalStreamer extends Streamer {
 
     /**
      * {@code
-     *      Streamer
+     * Streamer
      * ^               |
      * |               v
      * Provider    Collector
@@ -184,7 +184,6 @@ public static void attachFilter( AlgNode modify, AlgBuilder algBuilder, RexBuild
             }
         }
 
-
         attachFilter( modify.getEntity(), algBuilder, rexBuilder, indexes );
     }
 

core/src/main/java/org/polypheny/db/algebra/logical/document/LogicalDocumentAggregate.java

@@ -53,8 +53,6 @@ private static LogicalDocumentAggregate create_( final AlgNode input, @Nullable
     }
 
 
-
-
     @Override
     public AlgNode copy( AlgTraitSet traitSet, List<AlgNode> inputs ) {
         return new LogicalDocumentAggregate( inputs.get( 0 ).getCluster(), traitSet, inputs.get( 0 ), getGroup().orElse( null ), aggCalls );

core/src/main/java/org/polypheny/db/algebra/logical/package-info.java

@@ -1,4 +1,3 @@
-
 /**
  * Defines logical relational expressions.
  *
@@ -10,4 +9,3 @@
  */
 
 package org.polypheny.db.algebra.logical;
-

core/src/main/java/org/polypheny/db/algebra/metadata/ChainedAlgMetadataProvider.java

@@ -133,7 +133,7 @@ public static AlgMetadataProvider of( List<AlgMetadataProvider> list ) {
     /**
      * Invocation handler that calls a list of {@link Metadata} objects, returning the first non-null value.
      */
-    private record ChainedInvocationHandler(List<Metadata> metadataList) implements InvocationHandler {
+    private record ChainedInvocationHandler( List<Metadata> metadataList ) implements InvocationHandler {
 
         private ChainedInvocationHandler( List<Metadata> metadataList ) {
             this.metadataList = ImmutableList.copyOf( metadataList );
@@ -162,4 +162,3 @@ public Object invoke( Object proxy, Method method, Object[] args ) throws Throwa
     }
 
 }
-

core/src/main/java/org/polypheny/db/algebra/metadata/package-info.java

@@ -1,7 +1,5 @@
-
 /**
  * Defines metadata interfaces and utilities for relational expressions.
  */
 
 package org.polypheny.db.algebra.metadata;
-

core/src/main/java/org/polypheny/db/algebra/mutable/package-info.java

@@ -1,4 +1,3 @@
-
 /**
  * Defines mutable relational expressions.
  *

core/src/main/java/org/polypheny/db/algebra/package-info.java

@@ -1,4 +1,3 @@
-
 /**
  * Defines relational expressions.
  *
@@ -11,4 +10,3 @@
  */
 
 package org.polypheny.db.algebra;
-

core/src/main/java/org/polypheny/db/algebra/rules/FilterScanRule.java

@@ -59,7 +59,6 @@
  * to a {@link BindableScan}.
  *
  * The {@link #INTERPRETER} variant allows an intervening {@link EnumerableInterpreter}.
- *
  */
 public abstract class FilterScanRule extends AlgOptRule {