Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock the Polypheny Home Directory #501

Merged
merged 56 commits into from
Aug 5, 2024
Merged

Lock the Polypheny Home Directory #501

merged 56 commits into from
Aug 5, 2024

Conversation

gartens
Copy link
Contributor

@gartens gartens commented Jun 25, 2024

Summary

Until now Polypheny used the port 7659 to determine if another instance is running and would then refuse to start. This approach fails to detect instances using other ports. This is especially a problem, if one of these instances were to use the same home directory. So to prevent this, create a .lock file in the home directory and lock it using facilities provided by the operating system. This way each home directory can only be used by one instance at a time.

There are also various other small improvements.

There is also a corresponding UI PR because a field is renamed.

Copy link
Member

@datomo datomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for me. Thx @gartens.

Copy link
Member

@vogti vogti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, @gartens, for this PR!

@vogti vogti merged commit da375ef into master Aug 5, 2024
31 of 32 checks passed
@vogti vogti deleted the various-improvements branch August 5, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants