Improve transaction handling in Prism Driver & Decimal validation #514

gartens · 2024-08-29T07:28:15Z

The main contribution of this PR are improvements to transaction handling in the Prism driver and decimal validation:

Ensure that statements objects used in the Prism driver belong to the current transaction (with a test that would have exposed this)
Ignore leading 0 in decimal number validation to match the documentation
Throw an exception when trying to create a statement for an inactive transaction (this exposed an issue in anyPrepareQuery)
Improve type derivation in prepared statements
Replace a few subtractions with the more appropriate Integer.compare

…n benchmarks (ycsb, gavel, tpcc, tpch, etc.),

This saves us from having to convert back from ParameterMetas in deriveType.

datomo and others added 11 commits August 26, 2024 13:40

found potential root cause and fix for deadlocks and random crashes i…

7e78573

…n benchmarks (ycsb, gavel, tpcc, tpch, etc.),

adjusted cast of number values

7e4e02c

Store AlgDataTypes alongside with ParameterMetas

9afeab3

This saves us from having to convert back from ParameterMetas in deriveType.

Improve a few compareTo methods

f75f739

Add a test exposing a problem in statement/transaction handling

e478de3

Do not allow creating new statements in inactive transactions

336cb0a

Ignore leading zero

62b33cb

Ensure that statements belong to the current transaction

cdc52dd

Remove/revert debug code

028552f

Move up a check to ensure we have a valid transaction after DDLs

df0b555

added handling for dynamic param in cottontail

afaf25c

Provide feedback